Don't special-case the Build condition.#2396
Conversation
knative-prow-robot
added
do-not-merge/work-in-progress
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@mattmoor: 0 warnings.
Details
In response to this:
To allow treating
BuildSucceededas a terminal condition when we adjust the model as outlined in knative/pkg#161, we need to pass it to theConditionSetconstructor. This flushes out the downstream changes of that.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
mattmoor
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
To allow treating `BuildSucceeded` as a terminal condition when we adjust the model as outlined in knative/pkg#161, we need to pass it to the `ConditionSet` constructor. This flushes out the downstream changes of that.
mattmoor
force-pushed
the
always-build
branch
from
3d2e009 to
ab49c92
Compare
|
The following is the coverage report on pkg/.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
To allow treating
BuildSucceededas a terminal condition when we adjust the model as outlined in knative/pkg#161, we need to pass it to theConditionSetconstructor. This flushes out the downstream changes of that.