Start to refactor the way builds are created.#2400
Start to refactor the way builds are created.#2400knative-prow-robot merged 1 commit intoknative:masterfrom
Conversation
We want to be able to elide build creation when that portion of the `ConfigurationSpec` remains unchanged. To support those, we need to remove assumptions that `MakeRevision` can directly synthesize an `ObjectReference` for the `Build` directly from the `Configuration`. The idea is that in a subsequent change, we will start to label builds using the schema outlined in knative#439 and potentially pass in an `ObjectReference` we have looked up instead. Progress towards: knative#439
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
size/L
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@mattmoor: 1 warning.
Details
In response to this:
We want to be able to elide build creation when that portion of the
ConfigurationSpecremains unchanged. To support those, we need to remove assumptions thatMakeRevisioncan directly synthesize anObjectReferencefor theBuilddirectly from theConfiguration.The idea is that in a subsequent change, we will start to label builds using the schema outlined in #439 and potentially pass in an
ObjectReferencewe have looked up instead.Progress towards: #439
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
| ) | ||
|
|
||
| func MakeRevision(config *v1alpha1.Configuration) *v1alpha1.Revision { | ||
| func MakeRevision(config *v1alpha1.Configuration, buildRef *corev1.ObjectReference) *v1alpha1.Revision { |
There was a problem hiding this comment.
Golint comments: exported function MakeRevision should have comment or be unexported. More info.
|
The following is the coverage report on pkg/.
|
|
/lgtm |
4 participants
We want to be able to elide build creation when that portion of the
ConfigurationSpecremains unchanged. To support those, we need to remove assumptions thatMakeRevisioncan directly synthesize anObjectReferencefor theBuilddirectly from theConfiguration.The idea is that in a subsequent change, we will start to label builds using the schema outlined in #439 and potentially pass in an
ObjectReferencewe have looked up instead.Progress towards: #439