Don't create builds unless the BuildSpec changes.#2402
Don't create builds unless the BuildSpec changes.#2402knative-prow-robot merged 1 commit intoknative:masterfrom
Conversation
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
size/L
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@mattmoor: 1 warning.
Details
In response to this:
Things like EnvVar updates should not trigger a fresh build, when a Build is specified in the ConfigurationSpec. This builds on prior changes to lookup a pre-existing build with the same spec before creating its own. This modifies the Build e2e tests to each perform an env-var only update to the configuration, and check that there are no differences in the resulting BuildRef.
Fixes: #439
WIP until #2401 (and it's dependencies) merge
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
| ) | ||
|
|
||
| func MakeRevision(config *v1alpha1.Configuration) *v1alpha1.Revision { | ||
| func MakeRevision(config *v1alpha1.Configuration, buildRef *corev1.ObjectReference) *v1alpha1.Revision { |
There was a problem hiding this comment.
Golint comments: exported function MakeRevision should have comment or be unexported. More info.
|
/test pull-knative-serving-unit-tests |
| } | ||
| } | ||
|
|
||
| func TestBuildAndServe(t *testing.T) { |
There was a problem hiding this comment.
Should we add an explicit e2e test where updating the build spec triggers a new build?
mattmoor
force-pushed
the
elide-build
branch
2 times, most recently
from
7b794d2 to
9759955
Compare
mattmoor
force-pushed
the
elide-build
branch
3 times, most recently
from
22166b8 to
1f27133
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mattmoor
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-knative-serving-unit-tests |
Things like EnvVar updates should not trigger a fresh build, when a Build is specified in the ConfigurationSpec. This builds on prior changes to lookup a pre-existing build with the same spec before creating its own. This modifies the Build e2e tests to each perform an env-var only update to the configuration, and check that there are no differences in the resulting BuildRef. Fixes: knative#439
|
The following is the coverage report on pkg/.
|
|
/lgtm |
|
/test pull-knative-serving-unit-tests |
|
/test pull-knative-serving-unit-tests @imikushin seeing a flare up of the global resync unit test flaking |
- due to changes in Knative Serving we need to add a full Build as an Unstructured object - we can then annotated the Build instead of the Revision to trigger a build - this is necessary after the changes in knative/serving#2402
- due to changes in Knative Serving we need to add a full Build as an Unstructured object - we can then annotated the Build instead of the Revision to trigger a build - this is necessary after the changes in knative/serving#2402
- due to changes in Knative Serving we need to add a full Build as an Unstructured object - we can then annotated the Build instead of the Revision to trigger a build - this is necessary after the changes in knative/serving#2402
- due to changes in Knative Serving we need to add a full Build as an Unstructured object - we can then annotated the Build instead of the Revision to trigger a build - this is necessary after the changes in knative/serving#2402
- due to changes in Knative Serving we need to add a full Build as an Unstructured object - we can then annotated the Build instead of the Revision to trigger a build - this is necessary after the changes in knative/serving#2402 - use GetBuild method from "reconciler/v1alpha1/configuration/resources" - fix tests to create Build objects that pass validation
- due to changes in Knative Serving we need to add a full Build as an Unstructured object - we can then annotated the Build instead of the Revision to trigger a build - this is necessary after the changes in knative/serving#2402 - use GetBuild method from "reconciler/v1alpha1/configuration/resources" - fix tests to create Build objects that pass validation - bump knative/build to 0.4.0
- due to changes in Knative Serving we need to add a full Build as an Unstructured object - we can then annotated the Build instead of the Revision to trigger a build - this is necessary after the changes in knative/serving#2402 - use GetBuild method from "reconciler/v1alpha1/configuration/resources" - fix tests to create Build objects that pass validation - bump knative/build to 0.4.0
4 participants
Things like EnvVar updates should not trigger a fresh build, when a Build is specified in the ConfigurationSpec. This builds on prior changes to lookup a pre-existing build with the same spec before creating its own. This modifies the Build e2e tests to each perform an env-var only update to the configuration, and check that there are no differences in the resulting BuildRef.
Fixes: #439
WIP until #2401 (and it's dependencies) merge