Add validation to the revisions provided in the revision list.#3045
Add validation to the revisions provided in the revision list.#3045knative-prow-robot merged 3 commits intoknative:masterfrom
Conversation
Since the revisions are supposed to be k8s objects, their names are supposed to follow the same naming convention. Thus validate the revision names to make sure the servive at least has a chance of serving something.
knative-prow-robot
added
the
size/M
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@vagababov: 0 warnings.
Details
In response to this:
Since the revisions are supposed to be k8s objects, their names
are supposed to follow the same naming convention.
Thus validate the revision names to make sure the servive at least
has a chance of serving something./lint
/close #3034Fixes #3034
Also part of #2819.Proposed Changes
- Validate the revision names in the WebHook
- Add related tests.
/cc @mattmoor
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/test pull-knative-serving-integration-tests |
|
/retest |
|
😠 |
…ve#3045) * add validation for the revision entries * Add validation to the revisions provided in the revision list. Since the revisions are supposed to be k8s objects, their names are supposed to follow the same naming convention. Thus validate the revision names to make sure the servive at least has a chance of serving something.
3 participants
Since the revisions are supposed to be k8s objects, their names
are supposed to follow the same naming convention.
Thus validate the revision names to make sure the servive at least
has a chance of serving something.
/lint
/close #3034
Fixes #3034
Also part of #2819.
Proposed Changes
/cc @mattmoor