Skip to content

Add dgerd to list of serving-api-approvers#3228

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
dgerd:dgerd-approver
Feb 15, 2019
Merged

Add dgerd to list of serving-api-approvers#3228
knative-prow-robot merged 1 commit intoknative:masterfrom
dgerd:dgerd-approver

Conversation

@dgerd
Copy link
Copy Markdown

@dgerd dgerd commented Feb 14, 2019

From ROLES.md:

Reviewer of the codebase for at least 3 months or 50% of project lifetime, whichever is shorter

Total project lifetime: 380 days (2018-01-30 to 2019-02-14)
50% of project lifetime: 190 days

Earliest review: 2018-10-16, 121 days ago
https://github.com/knative/serving/pulls?utf8=%E2%9C%93&q=is%3Apr+reviewed-by%3Adgerd+sort%3Acreated-asc+

Primary reviewer for at least 10 substantial PRs to the codebase

Reviewed 21 L, XL, or XXL PRs
https://github.com/knative/serving/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Adgerd+reviewed-by%3Adgerd+label%3Asize%2FL+
https://github.com/knative/serving/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Adgerd+reviewed-by%3Adgerd+label%3Asize%2FXL+

10 substantial examples:

  1. Support set user-defined port to queue-proxy #2190
  2. Normative example for release mode #2044
  3. Refactor the Configuration following #2447 #2493
  4. Move the resource test under conformance. #2733
  5. Implement verification for route readiness for the runLatest. #2898
  6. Release mode processing for the route not being ready. #2948
  7. Strengthen our resource name validation. #3019
  8. Add possibility to create services in release mode #3070
  9. Some readability nits, I didn't get a chance to comment #3099
  10. Add one more case to cover @latest as part of the traffic split. #3104

Reviewed or merged at least 30 PRs to the codebase

Reviewed or merged 51 PRs
https://github.com/knative/serving/pulls?q=is%3Apr+reviewed-by%3Adgerd+is%3Aclosed
https://github.com/knative/serving/pulls?utf8=%E2%9C%93&q=is%3Apr+-reviewed-by%3Adgerd+is%3Aclosed+author%3Adgerd

Nominated by an area lead with no objections from other leads

Current API Core lead is @mattmoor.

/cc @evankanderson @mattmoor @vaikas-google @mdemirhan @tcnghia @imjasonh @josephburnett

/cc @grantr : Thank you for the template! 👍

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 14, 2019
@mattmoor mattmoor self-assigned this Feb 14, 2019
@mattmoor
Copy link
Copy Markdown
Member

Something something great responsibility. 🎉

Welcome to Serving API approvers.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgerd, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2019
@knative-prow-robot knative-prow-robot merged commit f14ba15 into knative:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants