Fix the sugared logger usage#3345
Merged
knative-prow-robot merged 9 commits intoMar 5, 2019
Merged
Conversation
While debugging tests this got so annoying, since the output is useless, so I had to go and clean this stuff up.
knative-prow-robot
added
the
size/M
markusthoemmes
approved these changes
Mar 1, 2019
Contributor
markusthoemmes
left a comment
markusthoemmes
left a comment
There was a problem hiding this comment.
One nit, LGTM overall though.
/approve
dgerd
reviewed
Mar 1, 2019
Contributor
Author
|
All done. |
dgerd
reviewed
Mar 1, 2019
| logger.Errorf("Failed to reconcile Service: %q failed to reconcile Configuration: %q; %v", service.Name, configName, zap.Error(err)) | ||
| logger.Errorw( | ||
| fmt.Sprintf("Failed to reconcile Service: %q failed to reconcile Configuration: %q", | ||
| service.Name, configName), err) |
There was a problem hiding this comment.
One more fix. :)
Suggested change
| service.Name, configName), err) | |
| service.Name, configName), zap.Error(err)) |
Contributor
Author
|
/test pull-knative-serving-integration-tests |
Contributor
Author
|
/test pull-knative-serving-integration-tests |
|
/lgtm |
|
The following is the coverage report on pkg/.
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgerd, markusthoemmes, mattmoor, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging tests this got so annoying,
since the output is useless, so I had to go
and clean this stuff up.
/lint
Fixes #
Proposed Changes
/cc @dgerd
/assign @dgerd
Dan, I believe, you had an issue for? Cursory search did not return anything.