Skip to content

Normalize Fatal(f) logging calls in main files.#3866

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
markusthoemmes:normalize-logging
Apr 24, 2019
Merged

Normalize Fatal(f) logging calls in main files.#3866
knative-prow-robot merged 2 commits into
knative:masterfrom
markusthoemmes:normalize-logging

Conversation

@markusthoemmes
Copy link
Copy Markdown
Contributor

@markusthoemmes markusthoemmes commented Apr 23, 2019

Small fixes to conform to the general "don't interpolate the err variable" we follow everywhere.

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 23, 2019
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 23, 2019
knative-prow-robot
knative-prow-robot reviewed Apr 23, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markusthoemmes: 0 warnings.

Details

In response to this:

Small fixes to conform to the general "don't interpolate the err variable" we follow everywhere.

Release Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 23, 2019
@markusthoemmes
Copy link
Copy Markdown
Contributor Author

markusthoemmes commented Apr 23, 2019

No idea what went south there

/test pull-knative-serving-unit-tests

vagababov
vagababov approved these changes Apr 23, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2019
@vagababov
Copy link
Copy Markdown
Contributor

vagababov commented Apr 23, 2019

You might need Matt's approval as well.

@markusthoemmes
Copy link
Copy Markdown
Contributor Author

markusthoemmes commented Apr 24, 2019

/assign @mattmoor

@mattmoor
Copy link
Copy Markdown
Member

mattmoor commented Apr 24, 2019

/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Apr 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, mattmoor, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2019
@knative-prow-robot knative-prow-robot merged commit 7104e95 into knative:master Apr 24, 2019
@grantr grantr mentioned this pull request Oct 2, 2019
Closed
@vagababov vagababov mentioned this pull request Dec 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@greghaynes greghaynes Awaiting requested review from greghaynes

@mattmoor mattmoor Awaiting requested review from mattmoor

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

+1 more reviewer

@vagababov vagababov vagababov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vagababov vagababov

@mattmoor mattmoor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@markusthoemmes @vagababov @mattmoor @knative-prow-robot @googlebot