Clean up one of the TODO's and match public service name to the revision#3915
Conversation
There is no reason, why revision public service name should be different from the revision. So do just that.
knative-prow-robot
left a comment
There was a problem hiding this comment.
@vagababov: 0 warnings.
Details
In response to this:
There is no reason, why revision public service name should be different
from the revision.
So do just that./lint
Fixes #1997Proposed Changes
- use the revision name as the public service name
- clean up tests
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
The following is the coverage report on pkg/.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tcnghia, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There is no reason, why revision public service name should be different
from the revision.
So do just that.
/lint
Fixes #1997
Proposed Changes
/cc @mattmoor @tcnghia