Skip to content

Clean up one of the TODO's and match public service name to the revision#3915

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
vagababov:1997-clean-up-svc-name
Apr 26, 2019
Merged

Clean up one of the TODO's and match public service name to the revision#3915
knative-prow-robot merged 1 commit into
knative:masterfrom
vagababov:1997-clean-up-svc-name

Conversation

@vagababov
Copy link
Copy Markdown
Contributor

There is no reason, why revision public service name should be different
from the revision.
So do just that.

/lint
Fixes #1997

Proposed Changes

  • use the revision name as the public service name
  • clean up tests

/cc @mattmoor @tcnghia

There is no reason, why revision public service name should be different
from the revision.
So do just that.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 26, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 26, 2019
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagababov: 0 warnings.

Details

In response to this:

There is no reason, why revision public service name should be different
from the revision.
So do just that.

/lint
Fixes #1997

Proposed Changes

  • use the revision name as the public service name
  • clean up tests

/cc @mattmoor @tcnghia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/autoscaling/hpa/hpa.go Do not exist 93.8%
pkg/reconciler/autoscaling/kpa/kpa.go Do not exist 91.4%
pkg/reconciler/revision/revision.go Do not exist 90.8%
pkg/reconciler/route/resources/cluster_ingress.go Do not exist 100.0%
pkg/reconciler/route/route.go Do not exist 92.1%
pkg/reconciler/serverlessservice/resources/names/names.go Do not exist 100.0%
pkg/reconciler/serverlessservice/resources/services.go Do not exist 100.0%
pkg/reconciler/serverlessservice/serverlessservice.go Do not exist 89.9%

@tcnghia
Copy link
Copy Markdown
Contributor

tcnghia commented Apr 26, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tcnghia, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 7440f53 into knative:master Apr 26, 2019
@vagababov vagababov deleted the 1997-clean-up-svc-name branch June 7, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revision should manage activation

5 participants