Skip to content

Unindent the code in handleScaleToZero#4036

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
vagababov:unindent
May 8, 2019
Merged

Unindent the code in handleScaleToZero#4036
knative-prow-robot merged 1 commit intoknative:masterfrom
vagababov:unindent

Conversation

@vagababov
Copy link
Copy Markdown
Contributor

@vagababov vagababov commented May 8, 2019

Simple change, but I think this easier to read and follow than the long if case.

/cc @markusthoemmes

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 8, 2019
@knative-prow-robot knative-prow-robot added area/API API objects and controllers size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/autoscale approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 8, 2019
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented May 8, 2019

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/autoscaling/kpa/scaler.go 84.4% 85.9% 1.5

@vagababov
Copy link
Copy Markdown
Contributor Author

vagababov commented May 8, 2019

🥺

markusthoemmes
markusthoemmes approved these changes May 8, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented May 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 4482842 into knative:master May 8, 2019
@joshrider joshrider mentioned this pull request May 8, 2019
Merged
@vagababov vagababov deleted the unindent branch June 7, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@markusthoemmes markusthoemmes markusthoemmes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@markusthoemmes markusthoemmes

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vagababov @knative-metrics-robot @knative-prow-robot @markusthoemmes @googlebot