Skip to content

Validate that terminal is not allowed in container#4037

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
triggermesh:terminal-validate-test
May 8, 2019
Merged

Validate that terminal is not allowed in container#4037
knative-prow-robot merged 1 commit intoknative:masterfrom
triggermesh:terminal-validate-test

Conversation

@tzununbekov
Copy link
Copy Markdown
Contributor

Fixes #4027

Proposed Changes

Conformance test validates that stdin, stdinOnce, and tty cannot be set in container runtime

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 8, 2019
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 8, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

Hi @tzununbekov. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 8, 2019
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tzununbekov: 0 warnings.

Details

In response to this:

Fixes #4027

Proposed Changes

Conformance test validates that stdin, stdinOnce, and tty cannot be set in container runtime

Release Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label May 8, 2019
@vagababov
Copy link
Copy Markdown
Contributor

/ok-to-test
/assign @dgerd

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 8, 2019
@dgerd
Copy link
Copy Markdown

dgerd commented May 8, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgerd, tzununbekov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2019
@dgerd
Copy link
Copy Markdown

dgerd commented May 8, 2019

/test pull-knative-serving-integration-tests

@knative-prow-robot knative-prow-robot merged commit f24fc0b into knative:master May 8, 2019
@tzununbekov tzununbekov deleted the terminal-validate-test branch May 9, 2019 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate stdin, stdinOnce, and tty cannot be set in conformance tests

5 participants