Surface deployment replica failure status by edwardstudy · Pull Request #4136 · knative/serving

edwardstudy · 2019-05-21T06:23:20Z

Fixes #496

Proposed Changes

Following spec, surfaced deployment replica failure due ti insufficient quota, limit ranges, etc.

Release Note

NONE

knative-prow-robot

@edwardstudy: 1 warning.

Details

In response to this:

Fixes #496

Proposed Changes

Following spec, surfaced deployment replica failure due ti insufficient quota, limit ranges, etc.

Release Note
NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow-robot · 2019-05-21T06:23:35Z

Hi @edwardstudy. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vagababov · 2019-05-21T06:48:29Z

/ok-to-test

markusthoemmes · 2019-07-01T07:57:45Z

@edwardstudy sorry that this has not yet gotten any reviews. Do you mind rebasing this PR? I vaguely recall a slew of PRs in similar vein, so maybe check if this is still needed?

knative-prow-robot · 2019-07-02T02:55:15Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: edwardstudy
To complete the pull request process, please assign mattmoor
You can assign the PR to them by writing /assign @mattmoor in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

edwardstudy · 2019-07-02T02:58:06Z

@markusthoemmes Hi, thx for reply. I rebased.

This PR is surfacing a condition about underlying Deployment issues not logging stuff.

vagababov

/lint

knative-prow-robot

@vagababov: 1 warning.

Details

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow-robot · 2019-07-02T03:28:08Z

 	revCondSet.Manage(rs).MarkFalse(RevisionConditionResourcesAvailable, "ProgressDeadlineExceeded", message)
 }

+func (rs *RevisionStatus) MarkNoDeployment(message string) {


Golint comments: exported method RevisionStatus.MarkNoDeployment should have comment or be unexported. More info.

knative-metrics-robot · 2019-07-04T09:47:08Z

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/serving/v1alpha1/revision_lifecycle.go	78.2%	78.6%	0.4

knative-prow-robot · 2019-07-04T09:49:59Z

@edwardstudy: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-knative-serving-go-coverage	`613ca33`	link	`/test pull-knative-serving-go-coverage`
pull-knative-serving-unit-tests	`613ca33`	link	`/test pull-knative-serving-unit-tests`
pull-knative-serving-build-tests	`613ca33`	link	`/test pull-knative-serving-build-tests`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

markusthoemmes

Another rebase required I fear.

/assign @jonjohnsonjr

I think you've been looking into this in detail?

markusthoemmes · 2019-08-14T08:39:20Z

@edwardstudy any news?

markusthoemmes · 2019-08-21T10:49:40Z

Going to naively close this. @edwardstudy please reopen this if you want to rebase it and pick it back up. I'm not sure how much is left after @jonjohnsonjr recent PRs.

/close

knative-prow-robot · 2019-08-21T10:49:41Z

@markusthoemmes: Closed this PR.

Details

In response to this:

Going to naively close this. @edwardstudy please reopen this if you want to rebase it and pick it back up. I'm not sure how much is left after @jonjohnsonjr recent PRs.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 21, 2019

knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 21, 2019

knative-prow-robot reviewed May 21, 2019

View reviewed changes

Comment thread pkg/apis/serving/v1alpha1/revision_types.go Outdated

knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 21, 2019

knative-prow-robot added the area/API API objects and controllers label May 21, 2019

knative-prow-robot requested review from dprotaso and tcnghia May 21, 2019 06:23

edwardstudy force-pushed the ed/issue-496 branch from 1f2093e to f718f81 Compare May 21, 2019 06:45

knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 21, 2019

edwardstudy mentioned this pull request May 22, 2019

Surface Revision quota problems #496

Closed

markusthoemmes mentioned this pull request Jul 1, 2019

Send logs for pods in bad status #4572

Closed

edwardstudy force-pushed the ed/issue-496 branch from f718f81 to 9ab75c0 Compare July 2, 2019 02:54

knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Jul 2, 2019

vagababov reviewed Jul 2, 2019

View reviewed changes

knative-prow-robot reviewed Jul 2, 2019

View reviewed changes

edwardstudy force-pushed the ed/issue-496 branch 3 times, most recently from c366ecd to 88f53fc Compare July 4, 2019 08:17

Surface deployment replica failure status(knative#496)

613ca33

edwardstudy force-pushed the ed/issue-496 branch from 88f53fc to 613ca33 Compare July 4, 2019 09:43

markusthoemmes reviewed Jul 15, 2019

View reviewed changes

knative-prow-robot assigned jonjohnsonjr Jul 15, 2019

markusthoemmes mentioned this pull request Aug 7, 2019

Refactor deployment status propagation #5077

Merged

knative-prow-robot closed this Aug 21, 2019

Conversation

edwardstudy commented May 21, 2019

Proposed Changes

Uh oh!

knative-prow-robot left a comment

Choose a reason for hiding this comment

Proposed Changes

Uh oh!

Uh oh!

knative-prow-robot commented May 21, 2019

Uh oh!

vagababov commented May 21, 2019

Uh oh!

markusthoemmes commented Jul 1, 2019

Uh oh!

knative-prow-robot commented Jul 2, 2019

Uh oh!

edwardstudy commented Jul 2, 2019

Uh oh!

vagababov left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot Jul 2, 2019

Choose a reason for hiding this comment

Uh oh!

knative-metrics-robot commented Jul 4, 2019

Uh oh!

knative-prow-robot commented Jul 4, 2019

Uh oh!

markusthoemmes left a comment

Choose a reason for hiding this comment

Uh oh!

markusthoemmes commented Aug 14, 2019

Uh oh!

markusthoemmes commented Aug 21, 2019

Uh oh!

knative-prow-robot commented Aug 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants