Skip to content

Replace the helloworld image by the pizzaplanetv1 image everywhere.#4690

Closed
markusthoemmes wants to merge 4 commits intoknative:masterfrom
markusthoemmes:remove-helloworld-image
Closed

Replace the helloworld image by the pizzaplanetv1 image everywhere.#4690
markusthoemmes wants to merge 4 commits intoknative:masterfrom
markusthoemmes:remove-helloworld-image

Conversation

@markusthoemmes
Copy link
Copy Markdown
Contributor

@markusthoemmes markusthoemmes commented Jul 10, 2019

Proposed Changes

  • Replaced the helloworld image with the pizzaplanetv1 image everywhere. It's as good a helloworld as anything.
  • Replaced all image references with constants.

Release Note

NONE

/assign @vagababov

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 10, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 10, 2019
knative-prow-robot
knative-prow-robot reviewed Jul 10, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markusthoemmes: 0 warnings.

Details

In response to this:

Proposed Changes

  • Replaced the helloworld image with the pizzaplanetv1 image everywhere. It's as good a helloworld as anything.
  • Replaced all image references with constants.

Release Note

NONE

/assign @vagababov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Jul 10, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2019
mattmoor
mattmoor reviewed Jul 10, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2019
dgerd
dgerd reviewed Jul 10, 2019
View reviewed changes
Copy link
Copy Markdown

@dgerd dgerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! Looks mostly good.

Comment thread test/conformance/api/v1alpha1/service_test.go
@dgerd
Copy link
Copy Markdown

dgerd commented Jul 10, 2019

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2019
@markusthoemmes markusthoemmes force-pushed the remove-helloworld-image branch from fb0d215 to c0a7572 Compare July 12, 2019 09:07
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 12, 2019

New changes are detected. LGTM label has been removed.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 12, 2019

@markusthoemmes: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-serving-integration-tests c0a7572 link /test pull-knative-serving-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dgerd
Copy link
Copy Markdown

dgerd commented Jul 15, 2019

@markusthoemmes New change looks good, but this needs a rebase now :(

@dgerd dgerd mentioned this pull request Jul 17, 2019
Merged
@markusthoemmes
Copy link
Copy Markdown
Contributor Author

markusthoemmes commented Jul 22, 2019

Dropping the ball on this. Too much other stuff to do. Feel free to pick it up @dgerd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

+2 more reviewers

@mattmoor mattmoor mattmoor left review comments

@dgerd dgerd dgerd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vagababov vagababov

@mattmoor mattmoor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@markusthoemmes @knative-prow-robot @dgerd @mattmoor @vagababov @googlebot