Skip to content

Do not assert against Generation in conformance tests #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobcatfish merged 1 commit into from
Mar 23, 2018
Merged

Do not assert against Generation in conformance tests #475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions test/conformance/route_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,16 +191,12 @@ var _ = Describe("Route", func() {
Context("Deploying an app with a pre-built container", func() {
It("Creates a route, serves traffic to it, and serves traffic to subsequent revisions", func() {
By("Creating a new Route")
createdRoute, err := routeClient.Create(route())
_, err := routeClient.Create(route())
Expect(err).NotTo(HaveOccurred())
Expect(createdRoute.Generation).To(Equal(int64(0)))
Expect(createdRoute.Spec.Generation).To(Equal(int64(1)))

By("Creating Configuration for the Route using the first image")
createdConfig, err := configClient.Create(configuration(imagePaths[0]))
_, err = configClient.Create(configuration(imagePaths[0]))
Expect(err).NotTo(HaveOccurred())
Expect(createdConfig.Generation).To(Equal(int64(0)))
Expect(createdConfig.Spec.Generation).To(Equal(int64(1)))

By("The Configuration will be updated with the Revision after it is created")
var revisionName string
Expand Down