Skip to content

Mark samples as either "app" or "function"#500

Merged
mattmoor merged 1 commit intoknative:masterfrom
evankanderson:classify
Mar 26, 2018
Merged

Mark samples as either "app" or "function"#500
mattmoor merged 1 commit intoknative:masterfrom
evankanderson:classify

Conversation

@evankanderson
Copy link
Member

Based on discussion with @mattmoor in #444 , marking configurations based on whether they create an application (have a "main" which creates an http server) or specify only a function (and assume web wrapper injection).

… a built-in HTTP server, or whether the server is injected by the framework.
@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 25, 2018
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to sweep .md too, but thanks for cleaning this up.

@evankanderson
Copy link
Member Author

I ran a grep -Rl "elafros.dev/type" . to find these files. (Which found some of the .tpl ones I'd missed earlier.)

Two other observations, having gone through all these files.

  1. Having a src_dir option to git would let us check in the source code alongside the templates, which would be nice.
  2. We only have one example of an injected function framework, and most of the rest of our apps are in Go. It would be nice to have some additional diversity in both language and between apps and functions.

@squee1945
Copy link

@evankanderson where is the example of the function framework?

@mattmoor
Copy link
Member

@squee1945 I bet he's talking about sample/steren-function, which isn't great.

@mattmoor mattmoor merged commit 94e7da5 into knative:master Mar 26, 2018
@evankanderson evankanderson deleted the classify branch March 26, 2018 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants