Fix race condition in TestMinScale that causes occasional flakes#5255
Fix race condition in TestMinScale that causes occasional flakes#5255knative-prow-robot merged 1 commit intoknative:masterfrom
TestMinScale that causes occasional flakes#5255Conversation
There is a race condition in `TestMinScale` where a deployment can reach `minScale` and then scale down before the test has a chance to observe that it has reached that `minScale`. This commit changes the test to observe the desired replicas of the deployment instead of the actual replicas.
knative-prow-robot
added
size/S
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@tanzeeb: 0 warnings.
Details
In response to this:
There is a race condition in
TestMinScalewhere a deployment can reach
minScaleand then scale down before the test has a chance to observe
that it has reached thatminScale.This commit changes the test to observe the desired replicas of the
deployment instead of the actual replicas.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
/assign @mattmoor |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, tanzeeb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
4 participants
There is a race condition in
TestMinScalewhere a deployment can reachminScaleand then scale down before the test has a chance to observethat it has reached that
minScale.This commit changes the test to observe the desired replicas of the
deployment instead of the actual replicas.