Use the correct zap sugared logger syntax#5747
Conversation
Fatalw needs either a zap.Field or key, value pairs in the variadic args.
knative-prow-robot
added
the
size/XS
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@grantr: 0 warnings.
Details
In response to this:
Fatalw needs either a zap.Field or
key, valuepairs in the variadic args.Fixes #5746
/lint
Proposed Changes
- Update Fatalw to correct syntax in webhook and autoscaler
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
The following jobs failed:
Automatically retrying due to test flakiness... |
vagababov
left a comment
vagababov
left a comment
There was a problem hiding this comment.
I thought a real "bunch" based on the issue :-)
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
Two can be a bunch!🍌 🍌 |
5 participants
Fatalw needs either a zap.Field or
key, valuepairs in the variadic args.Fixes #5746
/lint
Proposed Changes