Specify the APIVersion of the autoscaler target.#59
Merged
Conversation
Autoscaling was broken because the horizontal pod autoscaler was unable to find the deployment.
mattmoor
approved these changes
Feb 2, 2018
grantr
approved these changes
Feb 2, 2018
Contributor
grantr
left a comment
There was a problem hiding this comment.
Thanks for expanding the explanation!
dprotaso
added a commit
to dprotaso/serving
that referenced
this pull request
Sep 12, 2018
Includes: 8fc80de Few changes to the configmap package (knative#59)
knative-prow-robot
pushed a commit
that referenced
this pull request
Sep 12, 2018
* Bump knative/pkg to 8fc80de Includes: 8fc80de Few changes to the configmap package (#59) * Use updated configmap.Watcher New* method names
tcnghia
pushed a commit
to tcnghia/serving
that referenced
this pull request
Jun 8, 2020
Produced via: `./hack/update-deps.sh --upgrade && ./hack/update-codegen.sh` /assign shashwathi tanzeeb /cc shashwathi tanzeeb
nak3
referenced
this pull request
in nak3/serving
Dec 6, 2022
#59) * Add gRPC test work against OpenShift Routes * Fix typo Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autoscaling was broken because the horizontal pod autoscaler was unable to find the deployment. Message was "the HPA controller was unable to get the target's current scale: no matches for /, Kind=Deployment" and it showed / 80%.
Now the autoscale is able to find the deployment and shows the actual CPU usage.