Update test/adding_tests.md by MIBc · Pull Request #6345 · knative/serving

MIBc · 2019-12-27T09:09:29Z

Update test/adding_tests.md and test/README.md

Proposed Changes

update code example
update import path

knative-prow-robot · 2019-12-27T09:09:44Z

Hi @MIBc. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

MIBc · 2019-12-27T09:51:28Z

/assign @adrcunha

adrcunha

Thanks for updating the docs, just a few minor things.

/ok-to-test

taragu · 2020-01-02T16:18:43Z

 your existing [environment setup](../DEVELOPMENT.md#setup-your-environment).

-By importing `github.com/knative/serving/test` you get access to a global
+By importing `knative.dev/pgk/test` you get access to a global


Suggested change

By importing `knative.dev/pgk/test` you get access to a global

By importing `knative.dev/pkg/test` you get access to a global

taragu · 2020-01-02T16:35:39Z

- [`--tag`](#using-a-docker-tag)
- [`--ingressendpoint`](#using-a-custom-ingress-endpoint)
+- [All flags added by `knative/pkg/test`](https://github.com/knative/pkg/tree/master/test#flags) such as:
+  - [`--dockerrepo`](#overriding-docker-repo)


Should these be on the same indentation level as the last three flags?

I think knative/pkg/test flag and knative/serving/test flag can be same level.
The --dockerrepo, --tag, --ingressendpoint belong to knative/pkg/test. They are subset of knative/pkg/test flag.
The last three flags are special flag for knative/serving/test.

Ah got it. Thanks for the clarification!

taragu · 2020-01-02T16:53:15Z

+- `Istio objects`

 For example, to create a `Route`:



This line needs to be updated:

_, err = clients.ServingClient.Routes.Create(test.Route(namespaceName, routeName, configName))

-->

_, err = clients.ServingClient.Routes.Create(v1test.Route( test.ResourceNames{ Route: routeName, Config: configName, }))

taragu · 2020-01-02T16:57:51Z


 ```go
-err = test.WaitForRouteState(clients.ServingClient, routeName, test.AllRouteTrafficAtRevision(routeName, revisionName))
+err := v1alpha1testing.WaitForRouteState(clients.ServingClient, routeName, v1alpha1testing.AllRouteTrafficAtRevision(routeName, revisionName))


This needs to be updated because AllRouteTrafficAtRevision takes type ResourceNames as the argument.

taragu · 2020-01-02T16:58:48Z


 ```go
-err := test.WaitForRevisionState(clients.ServingClient, revisionName, test.IsRevisionReady(revisionName))
+err := v1alpha1testing.WaitForRevisionState(clients.ServingClient, revisionName, v1alpha1testing.IsRevisionReady(revisionName))


This needs to be updated because IsRevisionReady takes the revision object as the argument, not the name

The WaitForRevisionState also need to be updated.

Update test/adding_tests.md and test/README.md Fixes knative#6239

MIBc · 2020-01-05T14:45:28Z

Do you have any other comments? @adrcunha

adrcunha · 2020-01-06T18:44:10Z

Do you have any other comments? @adrcunha

I don't, so I'm approving. I'll let @taragu LGTM.

/approve

knative-prow-robot · 2020-01-06T18:44:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, MIBc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/OWNERS~~ [adrcunha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

taragu · 2020-01-07T13:38:48Z

/lgtm
Thanks @MIBc for the PR!

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 27, 2019

knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 27, 2019

knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 27, 2019

mattmoor reviewed Dec 27, 2019

View reviewed changes

knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Dec 27, 2019

knative-prow-robot requested review from chaodaiG and vagababov December 27, 2019 09:10

MIBc force-pushed the dev-master branch from 9efb292 to f9b02d7 Compare December 27, 2019 09:50

knative-prow-robot assigned adrcunha Dec 27, 2019

MIBc force-pushed the dev-master branch from f9b02d7 to e81bbd9 Compare December 27, 2019 09:56

adrcunha reviewed Dec 27, 2019

View reviewed changes

Comment thread test/adding_tests.md Outdated

Comment thread test/adding_tests.md Outdated

Comment thread test/adding_tests.md

knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 27, 2019

MIBc force-pushed the dev-master branch from e81bbd9 to c2921a0 Compare January 2, 2020 02:04

taragu reviewed Jan 2, 2020

View reviewed changes

MIBc force-pushed the dev-master branch from c2921a0 to e9e0ceb Compare January 3, 2020 09:35

knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 3, 2020

MIBc force-pushed the dev-master branch from e9e0ceb to 76822a3 Compare January 3, 2020 09:41

Update test/adding_tests.md

acb8c5f

Update test/adding_tests.md and test/README.md Fixes knative#6239

MIBc force-pushed the dev-master branch from 76822a3 to acb8c5f Compare January 3, 2020 09:52

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2020

knative-prow-robot assigned taragu Jan 7, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2020

knative-prow-robot merged commit be0e1f1 into knative:master Jan 7, 2020

MIBc mentioned this pull request Aug 28, 2020

REQUEST: New membership for MIBc knative/community#243

Closed

	By importing `knative.dev/pgk/test` you get access to a global
	By importing `knative.dev/pkg/test` you get access to a global

Conversation

MIBc commented Dec 27, 2019

Proposed Changes

Uh oh!

knative-prow-robot commented Dec 27, 2019

Uh oh!

MIBc commented Dec 27, 2019

Uh oh!

adrcunha left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MIBc Jan 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MIBc commented Jan 5, 2020

Uh oh!

adrcunha commented Jan 6, 2020

Uh oh!

knative-prow-robot commented Jan 6, 2020

Uh oh!

taragu commented Jan 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MIBc Jan 3, 2020 •

edited

Loading