Skip to content

Remove k8s resource in e2e test#6530

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
MIBc:adjust-defer
Feb 26, 2020
Merged

Remove k8s resource in e2e test#6530
knative-prow-robot merged 1 commit intoknative:masterfrom
MIBc:adjust-defer

Conversation

@MIBc
Copy link
Copy Markdown
Contributor

@MIBc MIBc commented Jan 15, 2020 •
edited
Loading

Proposed Changes

  • Remove k8s resource in autoscale test if steup function meet error.
  • Set defer function before t.Fatalf called. Otherwise the defer function may not be called.

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 15, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 15, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jan 15, 2020

Hi @MIBc. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Jan 15, 2020
@MIBc
Copy link
Copy Markdown
Contributor Author

MIBc commented Jan 15, 2020

/assign @tcnghia

markusthoemmes
markusthoemmes approved these changes Feb 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the one comment for the grpc connections.

Comment thread test/e2e/grpc_test.go Outdated
if conn != nil {
conn.Close()
}
}()
Copy link
Copy Markdown
Contributor

@markusthoemmes markusthoemmes Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change actually do anything? I looked through grpc's Dial function and it seems to always return nil in case of an error anyway. It also has it's own defer to tear down connections in case of an error.

Copy link
Copy Markdown
Contributor Author

@MIBc MIBc Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I have recovered it.

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2020
@markusthoemmes
Copy link
Copy Markdown
Contributor

markusthoemmes commented Feb 24, 2020

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 24, 2020
@markusthoemmes
Copy link
Copy Markdown
Contributor

markusthoemmes commented Feb 24, 2020

@MIBc Do you mind rebasing this?

@markusthoemmes
Copy link
Copy Markdown
Contributor

markusthoemmes commented Feb 24, 2020

/assign

@MIBc
Copy link
Copy Markdown
Contributor Author

MIBc commented Feb 24, 2020

@MIBc Do you mind rebasing this?

OK.

@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 24, 2020
markusthoemmes
markusthoemmes reviewed Feb 24, 2020
View reviewed changes
Comment thread test/e2e/minscale_readiness_test.go Outdated
Image: "helloworld",
}
test.CleanupOnInterrupt(func() { test.TearDown(clients, names) })
defer test.TearDown(clients, names)
Copy link
Copy Markdown
Contributor

@markusthoemmes markusthoemmes Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like some rebase weirdness. The respective calls are already in place.

Copy link
Copy Markdown
Contributor Author

@MIBc MIBc Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@MIBc
Remove k8s resource in e2e test
77ca983 
1. Remove k8s resource in autoscale test if `steup` function meet error.
2. Set `defer` function before t.Fatalf called. Otherwise the `defer` function may not be called.
@MIBc
Copy link
Copy Markdown
Contributor Author

MIBc commented Feb 24, 2020

/retest

markusthoemmes
markusthoemmes approved these changes Feb 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Feb 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, MIBc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Feb 24, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-integration-tests pull-knative-serving-integration-tests 1/3

Automatically retrying due to test flakiness...
/test pull-knative-serving-integration-tests

@MIBc
Copy link
Copy Markdown
Contributor Author

MIBc commented Feb 25, 2020

/retest

2 similar comments
@MIBc
Copy link
Copy Markdown
Contributor Author

MIBc commented Feb 25, 2020

/retest

@MIBc
Copy link
Copy Markdown
Contributor Author

MIBc commented Feb 26, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit 744090c into knative:master Feb 26, 2020
@MIBc MIBc deleted the adjust-defer branch February 26, 2020 13:57
@MIBc MIBc mentioned this pull request Aug 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coryrc coryrc Awaiting requested review from coryrc

@vagababov vagababov Awaiting requested review from vagababov

1 more reviewer

@markusthoemmes markusthoemmes markusthoemmes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tcnghia tcnghia

@markusthoemmes markusthoemmes

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MIBc @knative-prow-robot @markusthoemmes @knative-test-reporter-robot @tcnghia @googlebot