Skip to content

Revert PR 6161#7137

Merged
knative-prow-robot merged 2 commits intoknative:masterfrom
rgregg:revert-pr-6161
Mar 4, 2020
Merged

Revert PR 6161#7137
knative-prow-robot merged 2 commits intoknative:masterfrom
rgregg:revert-pr-6161

Conversation

@rgregg
Copy link
Copy Markdown
Contributor

@rgregg rgregg commented Mar 4, 2020

Based on a unanimous vote from the steering committee, we are temporarily reverting #6161 and reinstating approver permissions for @mdemirhan while we clarify the process through which approver permissions can be removed by the community.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 4, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2020
@mattmoor
Copy link
Copy Markdown
Member

mattmoor commented Mar 4, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, rgregg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2020
@knative-prow-robot knative-prow-robot merged commit fdf14f1 into knative:master Mar 4, 2020
@bsnchan
Copy link
Copy Markdown
Contributor

bsnchan commented Mar 4, 2020

For transparency sake, here is the issue to track for clarification around community process to remove approvers: knative/community#103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants