Revision conversion changes for multi container support#7245
Merged
knative-prow-robot merged 2 commits intoknative:masterfrom Mar 23, 2020
Merged
Revision conversion changes for multi container support#7245knative-prow-robot merged 2 commits intoknative:masterfrom
knative-prow-robot merged 2 commits intoknative:masterfrom
Conversation
knative-prow-robot
added
the
size/M
Contributor
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@savitaashture: 0 warnings.
Details
In response to this:
Proposed Changes
- Added conversion changes between v1alpha1, v1beta1 & v1
Release Note
None/assign @dprotaso
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
savitaashture
changed the title
Contributor
Author
vagababov
reviewed
Mar 18, 2020
Contributor
Author
|
@vagababov Addressed review comments Please have a look |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Parts of #5822 #3384
Proposed Changes
Release Note