Skip to content

TestSingleConcurrency - log more information on failure#7392

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
mgencur:single_concurrency_test_logging
Mar 26, 2020
Merged

TestSingleConcurrency - log more information on failure#7392
knative-prow-robot merged 1 commit intoknative:masterfrom
mgencur:single_concurrency_test_logging

Conversation

@mgencur
Copy link
Copy Markdown
Contributor

@mgencur mgencur commented Mar 26, 2020

Fixes #

Proposed Changes

Release Note

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 26, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 26, 2020
knative-prow-robot
knative-prow-robot reviewed Mar 26, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgencur: 0 warnings.

Details

In response to this:

Fixes #

Proposed Changes

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Mar 26, 2020
@mgencur mgencur mentioned this pull request Mar 26, 2020
Closed
mattmoor
mattmoor reviewed Mar 26, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Mar 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Mar 26, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-integration-tests:

test/e2e.TestServiceToServiceCall
test/e2e.TestSubrouteVisibilityPublicToPrivate
test/e2e.TestServiceToServiceCallViaActivator/a-disabled

@mgencur
Copy link
Copy Markdown
Contributor Author

mgencur commented Mar 26, 2020

/retest
These failures are unrelated to changes in this PR.

@knative-prow-robot knative-prow-robot merged commit dd59bcf into knative:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@vagababov vagababov Awaiting requested review from vagababov

+1 more reviewer

@mattmoor mattmoor mattmoor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mattmoor mattmoor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mgencur @knative-prow-robot @knative-test-reporter-robot @mattmoor @googlebot