Skip to content

[WIP] Ensure serving resources override KRShaped interface#7847

Closed
whaught wants to merge 15 commits intoknative:masterfrom
whaught:krshaped
Closed

[WIP] Ensure serving resources override KRShaped interface#7847
whaught wants to merge 15 commits intoknative:masterfrom
whaught:krshaped

Conversation

@whaught
Copy link
Copy Markdown
Contributor

@whaught whaught commented May 5, 2020

Issue #1226

Proposed Changes

  • Override the KRShaped interface for all of the serving API resources

Release Note


@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 5, 2020
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/API API objects and controllers area/autoscale area/networking labels May 5, 2020
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whaught: 0 warnings.

Details

In response to this:

Issue #1226

Proposed Changes

  • Override the KRShaped interface for all of the serving API resources

Release Note


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 6, 2020
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 6, 2020
@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 7, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: whaught
To complete the pull request process, please assign evankanderson, jrbancel
You can assign the PR to them by writing /assign @evankanderson @jrbancel in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/autoscaling/v1alpha1/metric_types.go Do not exist 100.0%
pkg/apis/autoscaling/v1alpha1/pa_types.go Do not exist 100.0%
pkg/apis/networking/v1alpha1/certificate_types.go Do not exist 100.0%
pkg/apis/networking/v1alpha1/ingress_types.go Do not exist 100.0%
pkg/apis/networking/v1alpha1/serverlessservice_types.go Do not exist 100.0%
pkg/apis/serving/v1/configuration_lifecycle.go 92.9% 93.3% 0.5
pkg/apis/serving/v1/configuration_types.go 0.0% 100.0% 100.0
pkg/apis/serving/v1/revision_lifecycle.go 87.2% 87.5% 0.3
pkg/apis/serving/v1/revision_types.go 0.0% 100.0% 100.0
pkg/apis/serving/v1/route_types.go 0.0% 100.0% 100.0
pkg/apis/serving/v1/service_types.go 0.0% 100.0% 100.0
pkg/apis/serving/v1alpha1/configuration_types.go Do not exist 100.0%
pkg/apis/serving/v1alpha1/revision_lifecycle.go 89.3% 89.5% 0.1
pkg/apis/serving/v1alpha1/revision_types.go Do not exist 100.0%
pkg/apis/serving/v1alpha1/route_types.go Do not exist 100.0%
pkg/apis/serving/v1alpha1/service_lifecycle.go 89.3% 89.7% 0.4
pkg/apis/serving/v1alpha1/service_types.go Do not exist 100.0%

@whaught
Copy link
Copy Markdown
Contributor Author

whaught commented May 7, 2020

split this up by area

/close

@whaught whaught closed this May 7, 2020
@knative-test-reporter-robot
Copy link
Copy Markdown

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-integration-tests:

test/conformance/api/v1.TestUpdateConfigurationMetadata
test/conformance/api/v1.TestContainerErrorMsg
test/conformance/api/v1.TestContainerExitingMsg
test/conformance/api/v1.TestTranslation
test/conformance/api/v1.TestServiceAccountValidation
test/conformance/api/v1.TestService
test/conformance/api/v1.TestContainerExitingMsg/http
test/conformance/api/v1.TestContainerExitingMsg/tcp

and 37 more.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@whaught: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-serving-integration-tests 3573d7f link /test pull-knative-serving-integration-tests
pull-knative-serving-upgrade-tests 3573d7f link /test pull-knative-serving-upgrade-tests
pull-knative-serving-build-tests 50a194d link /test pull-knative-serving-build-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whaught whaught deleted the krshaped branch May 18, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/API API objects and controllers area/autoscale area/networking cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants