Skip to content

Implement KRShaped for serving v1#7878

Merged
knative-prow-robot merged 13 commits intoknative:masterfrom
whaught:servingv1-shape
May 18, 2020
Merged

Implement KRShaped for serving v1#7878
knative-prow-robot merged 13 commits intoknative:masterfrom
whaught:servingv1-shape

Conversation

@whaught
Copy link
Copy Markdown
Contributor

@whaught whaught commented May 7, 2020 •
edited
Loading

Issue knative/pkg#1226

Proposed Changes

  • Implements the KRShaped interface for the v1 serving resources
    • Will allow common logic in the generated reconciler

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 7, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 7, 2020
knative-prow-robot
knative-prow-robot reviewed May 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whaught: 0 warnings.

Details

In response to this:

Issue #1226

Proposed Changes

  • Implements the KRShaped interface for the v1 serving resources
    • Will allow common logic in the generated reconciler

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the area/API API objects and controllers label May 7, 2020
@whaught
Copy link
Copy Markdown
Contributor Author

whaught commented May 7, 2020

/assign @dprotaso

@whaught whaught mentioned this pull request May 8, 2020
Closed
dprotaso
dprotaso reviewed May 8, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dprotaso dprotaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue #1226 seems unrelated to this PR - what were you linking?

Comment thread pkg/apis/serving/v1/configuration_types.go Outdated
Comment thread pkg/apis/serving/v1/configuration_lifecycle.go
julz
julz reviewed May 12, 2020
View reviewed changes
Comment thread pkg/apis/serving/v1/configuration_lifecycle_test.go Outdated
julz
julz reviewed May 12, 2020
View reviewed changes
Comment thread pkg/apis/serving/v1/revision_types.go Outdated
@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented May 13, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:

pkg/apis/serving/v1.[build failed]

@whaught whaught changed the title Implement KRShaped for serving v1 [WIP] Implement KRShaped for serving v1 May 14, 2020
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2020
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2020
@whaught whaught changed the title [WIP] Implement KRShaped for serving v1 Implement KRShaped for serving v1 May 18, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2020
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented May 18, 2020

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/serving/v1/configuration_lifecycle.go 92.9% 93.3% 0.5
pkg/apis/serving/v1/configuration_types.go 0.0% 100.0% 100.0
pkg/apis/serving/v1/revision_lifecycle.go 87.2% 87.5% 0.3
pkg/apis/serving/v1/revision_types.go 0.0% 100.0% 100.0
pkg/apis/serving/v1/route_types.go 0.0% 100.0% 100.0
pkg/apis/serving/v1/service_types.go 0.0% 100.0% 100.0

@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented May 18, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented May 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2020
@whaught
Copy link
Copy Markdown
Contributor Author

whaught commented May 18, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit 99eb115 into knative:master May 18, 2020
@whaught whaught deleted the servingv1-shape branch May 18, 2020 20:43
tcnghia pushed a commit that referenced this pull request May 22, 2020
Revert "Implement KRShaped for serving v1 (#7878)"
889fd5a 
This reverts commit 99eb115.
tcnghia pushed a commit that referenced this pull request May 22, 2020
Revert "Implement KRShaped for serving v1 (#7878)"
92b2089 
This reverts commit 99eb115.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dprotaso dprotaso dprotaso left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@evankanderson evankanderson Awaiting requested review from evankanderson

+1 more reviewer

@julz julz julz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dprotaso dprotaso

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@whaught @knative-test-reporter-robot @knative-metrics-robot @dprotaso @knative-prow-robot @julz @googlebot