Skip to content

Implement krshaped for autoscaling#7880

Merged
knative-prow-robot merged 5 commits intoknative:masterfrom
whaught:pa-krshaped
May 7, 2020
Merged

Implement krshaped for autoscaling#7880
knative-prow-robot merged 5 commits intoknative:masterfrom
whaught:pa-krshaped

Conversation

@whaught
Copy link
Copy Markdown
Contributor

@whaught whaught commented May 7, 2020

Issue #1226

Proposed Changes

  • Implements the KRShaped interface for the pod autoscaling resources
    • Will allow common logic in the generated reconciler

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 7, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/API API objects and controllers area/autoscale labels May 7, 2020
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whaught: 0 warnings.

Details

In response to this:

Issue #1226

Proposed Changes

  • Implements the KRShaped interface for the pod autoscaling resources
    • Will allow common logic in the generated reconciler

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits.
I did not apply them everywhere, but the idea is the same.

Comment thread pkg/apis/autoscaling/v1alpha1/metric_lifecycle_test.go Outdated
Comment thread pkg/apis/autoscaling/v1alpha1/metric_types_test.go Outdated
Comment thread pkg/apis/autoscaling/v1alpha1/metric_types_test.go Outdated
Comment thread pkg/apis/autoscaling/v1alpha1/metric_validation.go Outdated
@julz
Copy link
Copy Markdown
Contributor

julz commented May 7, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2020
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label May 7, 2020
Copy link
Copy Markdown
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vagababov, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2020
@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/autoscaling/v1alpha1/metric_types.go Do not exist 100.0%
pkg/apis/autoscaling/v1alpha1/pa_types.go Do not exist 100.0%

@knative-prow-robot knative-prow-robot merged commit 9e7bbf3 into knative:master May 7, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

@whaught: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-serving-unit-tests b0475bb link /test pull-knative-serving-unit-tests
pull-knative-serving-integration-tests b0475bb link /test pull-knative-serving-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whaught whaught deleted the pa-krshaped branch May 18, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants