Fix deprecation comment to reference existing field#7979
Merged
knative-prow-robot merged 1 commit intoknative:masterfrom May 24, 2020
Merged
Fix deprecation comment to reference existing field#7979knative-prow-robot merged 1 commit intoknative:masterfrom
knative-prow-robot merged 1 commit intoknative:masterfrom
Conversation
knative-prow-robot
added
size/XS
vagababov
reviewed
May 18, 2020
Contributor
vagababov
left a comment
vagababov
left a comment
There was a problem hiding this comment.
I swear I saw that fix already 😮
Contributor
Author
|
/assign @evankanderson |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, markusthoemmes, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Contributor
|
/verify-owners |
|
The following jobs failed:
Automatically retrying due to test flakiness... |
Contributor
Author
|
/retest |
1 similar comment
Member
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new field ended up landing as
ContainerStatuses[]rather thanImageDigests[]so the deprecation message refers to a non-existent field.(@vagababov fixed one of these in #7749 but missed a spot 😉).