Skip to content

Add route consistency retry to new logging E2E test. #8324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Jul 13, 2020
Merged

Add route consistency retry to new logging E2E test. #8324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions test/e2e/logging_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import (
"k8s.io/apimachinery/pkg/util/wait"

"knative.dev/pkg/system"
pkgTest "knative.dev/pkg/test"
"knative.dev/pkg/test/logstream"
"knative.dev/serving/pkg/apis/autoscaling"
"knative.dev/serving/pkg/network"
Expand Down Expand Up @@ -68,9 +69,16 @@ func TestRequestLogs(t *testing.T) {
t.Fatalf("Failed to create initial Service: %v: %v", names.Service, err)
}

_, err = sendRequest(t, clients, test.ServingFlags.ResolvableDomain, resources.Route.Status.URL.URL())
_, err = pkgTest.WaitForEndpointState(
Copy link
Copy Markdown
Contributor

@yanweiguo yanweiguo Jun 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't know why we need this.

Copy link
Copy Markdown
Contributor Author

@markusthoemmes markusthoemmes Jun 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because downstream projects might use external domains that actually need DNS setup for example, or external loadbalancers. It's a bandaid I brought up multiple times maybe I should bring it up to Networking WG again. It needs to be well understood and harder to hold wrong.

Copy link
Copy Markdown
Contributor

@tcnghia tcnghia Jun 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you were thinking of keeping the bandaid behind a flag?

Copy link
Copy Markdown
Contributor

@yanweiguo yanweiguo Jun 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment for it?

Copy link
Copy Markdown
Contributor

@mgencur mgencur Jun 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an open PR to add the flag! #7390

clients.KubeClient,
t.Logf,
resources.Route.Status.URL.URL(),
v1test.RetryingRouteInconsistency(pkgTest.MatchesAllOf(pkgTest.IsStatusOK, pkgTest.MatchesBody(test.HelloWorldText))),
"WaitForEndpointToServeText",
test.ServingFlags.ResolvableDomain,
test.AddRootCAtoTransport(t.Logf, clients, test.ServingFlags.Https))
if err != nil {
t.Fatal("Unexpected error when sending request to helloworld:", err)
t.Fatalf("The endpoint didn't serve the expected text %q: %v", test.HelloWorldText, err)
}

pod, err := theOnlyPod(clients, resources.Revision.Namespace, resources.Revision.Name)
Expand Down