Make log test more readable and dense it up.#8326
Make log test more readable and dense it up.#8326knative-prow-robot merged 3 commits intoknative:masterfrom
Conversation
- Parse loglines into structs for better readability. - Replace manual label creation with structured label creation. - Replace buffering with streaming handling of lines through buffered i/o.
knative-prow-robot
added
size/M
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@markusthoemmes: 1 warning.
Details
In response to this:
Proposed Changes
- Parse loglines into structs for better readability.
- Replace manual label creation with structured label creation.
- Replace buffering with streaming handling of lines through buffered i/o.
/assign @yanweiguo @vagababov
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
| } | ||
|
|
||
| type logLine struct { | ||
| HttpRequest httpRequest `json:"httpRequest"` |
There was a problem hiding this comment.
Golint naming: struct field HttpRequest should be HTTPRequest. More info.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
The following jobs failed:
Automatically retrying due to test flakiness... |
knative-prow-robot
added
size/L
markusthoemmes
force-pushed
the
optimize-log-test
branch
from
91d642e to
9beeb17
Compare
knative-prow-robot
added
size/M
vagababov
left a comment
vagababov
left a comment
There was a problem hiding this comment.
as mentioned in the other PR — perhaps just smush them together?
| type logLine struct { | ||
| HTTPRequest httpRequest `json:"httpRequest"` | ||
| } | ||
|
|
||
| type httpRequest struct { | ||
| RequestURL string `json:"requestUrl"` | ||
| UserAgent string `json:"userAgent"` | ||
| } |
|
@vagababov I'd rather not throw them together as one of them fixes a potential flake and this one is purely cosmetic. |
|
merge conflicts and stuff :) |
|
/lgtm |
6 participants
Proposed Changes
/assign @yanweiguo @vagababov