Skip to content

Update deps for serving#8375

Merged
knative-prow-robot merged 7 commits into
knative:masterfrom
whaught:deps
Jun 19, 2020
Merged

Update deps for serving#8375
knative-prow-robot merged 7 commits into
knative:masterfrom
whaught:deps

Conversation

@whaught
Copy link
Copy Markdown
Contributor

@whaught whaught commented Jun 19, 2020 •
edited
Loading

Proposed Changes

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 19, 2020
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 19, 2020
@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Jun 19, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:

pkg/leaderelection.TestValidateConfig
pkg/leaderelection.TestValidateConfig/OK
pkg/leaderelection.TestServingConfig
pkg/leaderelection.TestServingConfig/Default_config
pkg/leaderelection.TestServingConfig/Example_config

@knative-prow-robot knative-prow-robot added the area/API API objects and controllers label Jun 19, 2020
mattmoor
mattmoor reviewed Jun 19, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks, I have a follow-up that future proofs the rest of the unit tests now that the LeaderAware interface has landed (not strictly needed yet, but makes future changes auto-import), but missed this downstream break :(

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2020
@knative-prow-robot knative-prow-robot merged commit c37cc86 into knative:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

1 more reviewer

@mattmoor mattmoor mattmoor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mattmoor mattmoor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@whaught @knative-test-reporter-robot @knative-prow-robot @mattmoor @googlebot