Skip to content

Another attempt at flaky route test #8406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Jun 23, 2020
Merged

Another attempt at flaky route test #8406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/reconciler/route/route_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1389,6 +1389,12 @@ func TestUpdateDomainConfigMap(t *testing.T) {
t.Fatal("Failed to see route initial reconcile propagation:", err)
}

// Ensure we're operating on a copy, to make sure the update below
// generates an actual diff. Otherwise the value in the
// fake cache is going to be changed. Now, this update sometimes races with
// the CM update and since the update below is a noop (the same object
// is applied), noting happens and the test fails.
route = route.DeepCopy()
tc.apply(route, watcher)
fakerouteinformer.Get(ctx).Informer().GetIndexer().Add(route)
if _, err := routeClient.Update(route); err != nil {
Expand Down