Skip to content

Populate the routingState label and modified annotation in the Labeler#8604

Merged
knative-prow-robot merged 8 commits intoknative:masterfrom
whaught:labeler-next
Jul 15, 2020
Merged

Populate the routingState label and modified annotation in the Labeler#8604
knative-prow-robot merged 8 commits intoknative:masterfrom
whaught:labeler-next

Conversation

@whaught
Copy link
Copy Markdown
Contributor

@whaught whaught commented Jul 11, 2020 •
edited
Loading

Issue #8208

Proposed Changes

  • Populate the RoutingState label and RoutingStateModified timestamp annotations in the new labeler
  • Use a FakeClock for unit test stability of Now()

Release Note

Created a V2 Labeler that populates RoutingState and RoutingStateModified annotations on Revisions
This will be used for revision garbage collection

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 11, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 11, 2020
knative-prow-robot
knative-prow-robot reviewed Jul 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whaught: 0 warnings.

Details

In response to this:

Fixes #

Proposed Changes

  • Needs stable clock

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the area/API API objects and controllers label Jul 11, 2020
@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Jul 11, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:

pkg/reconciler/gc/v2.TestCollect
pkg/reconciler/gc/v2.TestCollect/keep_recent_lastPinned
pkg/reconciler/labeler.TestV2Reconcile
pkg/reconciler/labeler.TestV2Reconcile/label_pinned_revision
pkg/reconciler/labeler.TestV2Reconcile/no_ready_revision
pkg/reconciler/labeler.TestV2Reconcile/transitioning_route
pkg/reconciler/labeler.TestV2Reconcile/failure_adding_label_(revision)
pkg/reconciler/labeler.TestV2Reconcile/change_configurations

and 2 more.

@whaught whaught changed the title [WIP/DO NOT REVIEW] apply routingState and modified label Populate the routingState lable and modified annotation in the Labeler Jul 11, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2020
@whaught
Copy link
Copy Markdown
Contributor Author

whaught commented Jul 12, 2020

/test pull-knative-serving-integration-tests

@whaught whaught changed the title Populate the routingState lable and modified annotation in the Labeler Populate the routingState lablel and modified annotation in the Labeler Jul 13, 2020
whaught
whaught commented Jul 13, 2020
View reviewed changes
Comment thread pkg/apis/serving/v1/revision_helpers.go Outdated
@whaught
Copy link
Copy Markdown
Contributor Author

whaught commented Jul 13, 2020

/assign @vagababov @dprotaso

vagababov
vagababov reviewed Jul 14, 2020
View reviewed changes
Comment thread pkg/apis/serving/v1/revision_helpers.go Outdated
Comment thread pkg/reconciler/labeler/labelerv2_test.go Outdated
@whaught whaught mentioned this pull request Jul 14, 2020
Merged
vagababov
vagababov reviewed Jul 14, 2020
View reviewed changes
Comment thread pkg/reconciler/labeler/labelerv2_test.go Outdated
Comment thread pkg/reconciler/labeler/v2/accessors.go
@whaught whaught changed the title Populate the routingState lablel and modified annotation in the Labeler Populate the routingState label and modified annotation in the Labeler Jul 14, 2020
@vagababov
Copy link
Copy Markdown
Contributor

vagababov commented Jul 14, 2020

/lgtm
/assign mattmoor

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2020
@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Jul 15, 2020

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 15, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2020
@knative-prow-robot knative-prow-robot merged commit e071715 into knative:master Jul 15, 2020
@whaught whaught deleted the labeler-next branch July 16, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

@tcnghia tcnghia Awaiting requested review from tcnghia

@mattmoor mattmoor Awaiting requested review from mattmoor

+1 more reviewer

@vagababov vagababov vagababov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dprotaso dprotaso

@vagababov vagababov

@mattmoor mattmoor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@whaught @knative-test-reporter-robot @vagababov @dprotaso @knative-prow-robot @mattmoor @googlebot