Skip to content

Bump test timeout and correct failure messages#8820

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
julz:99p
Jul 27, 2020
Merged

Bump test timeout and correct failure messages#8820
knative-prow-robot merged 1 commit intoknative:masterfrom
julz:99p

Conversation

@julz
Copy link
Copy Markdown
Contributor

@julz julz commented Jul 27, 2020

We already tried bumping this once, but let's give it one more go since it flaked in CI again.

Also, fixed the failure messages when it does fail, which hopefully it won't any more ;-), and made failure messages consistent in use of "()" throughout file.

/assign @markusthoemmes

We already tried bumping this once, but let's give it one more go since
it's still flaking in CI every so often. Also fix the failure message when
it does fail. Which hopefully it won't any more ;-).

Also made failure messages consistent in use of "()" throughout file.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 27, 2020
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 27, 2020
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julz: 0 warnings.

Details

In response to this:

We already tried bumping this once, but let's give it one more go since it flaked in CI again.

Also, fixed the failure messages when it does fail, which hopefully it won't any more ;-), and made failure messages consistent in use of "()" throughout file.

/assign @markusthoemmes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Contributor

@yanweiguo yanweiguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: julz, yanweiguo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit efb014d into knative:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants