Add warnings to features that cannot safely be disabled again.#9260
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
516f937 to
3b308dc
Compare
|
The following jobs failed:
Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests: |
|
/retest |
|
/lgtm This is a great change. @JRBANCEL just added a docs page enumerating these, can we add the same warnings there? Just holding to make sure you see this, feel free to |
|
Yes, maybe it should be clarified what |
|
@JRBANCEL are you suggesting to add more meat in the CM or just in documentation? |
In the documentation, it should be enough. |
|
/unhold Alrighty then! |
Fixes #7241
Proposed Changes
Release Note
/assign @mattmoor @dprotaso