Skip to content

Add warnings to features that cannot safely be disabled again.#9260

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
markusthoemmes:feature-warnings
Sep 4, 2020
Merged

Add warnings to features that cannot safely be disabled again.#9260
knative-prow-robot merged 1 commit intoknative:masterfrom
markusthoemmes:feature-warnings

Conversation

@markusthoemmes
Copy link
Copy Markdown
Contributor

Fixes #7241

Proposed Changes

  • Adds a warning to the features that cannot safely be disabled after having been enabled once.
  • Reorder features a bit to group common features.
  • Slightly adjust comments to be consistent.

Release Note

NONE

/assign @mattmoor @dprotaso

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 2, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 2, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2020
@knative-test-reporter-robot
Copy link
Copy Markdown

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:

pkg/autoscaler/statforwarder.TestForwarderReconcile

@markusthoemmes
Copy link
Copy Markdown
Contributor Author

/retest

@mattmoor
Copy link
Copy Markdown
Member

mattmoor commented Sep 2, 2020

/lgtm
/hold

This is a great change. @JRBANCEL just added a docs page enumerating these, can we add the same warnings there? Just holding to make sure you see this, feel free to /unhold

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Sep 2, 2020
@JRBANCEL
Copy link
Copy Markdown
Contributor

JRBANCEL commented Sep 2, 2020

Yes, maybe it should be clarified what cannot b disabled mean in the docs.
It can be disabled but not before every Knative Service using the feature/extension is removed or stops using it.

@markusthoemmes
Copy link
Copy Markdown
Contributor Author

@JRBANCEL are you suggesting to add more meat in the CM or just in documentation?

@JRBANCEL
Copy link
Copy Markdown
Contributor

JRBANCEL commented Sep 3, 2020

@JRBANCEL are you suggesting to add more meat in the CM or just in documentation?

In the documentation, it should be enough.

@markusthoemmes
Copy link
Copy Markdown
Contributor Author

/unhold

Alrighty then!

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2020
@knative-prow-robot knative-prow-robot merged commit 4b20edb into knative:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[multi-container] toggling the default enable-multi-container from true to false will break things

7 participants