Skip to content

Move responsive-gc feature to allowed#9335

Merged
knative-prow-robot merged 2 commits intoknative:masterfrom
whaught:enable-gc
Sep 8, 2020
Merged

Move responsive-gc feature to allowed#9335
knative-prow-robot merged 2 commits intoknative:masterfrom
whaught:enable-gc

Conversation

@whaught
Copy link
Copy Markdown
Contributor

@whaught whaught commented Sep 8, 2020

Fixes #8208

Proposed Changes

  • Move the responsive garbage collection to Allowed. In this state the new collector will run, but the lastPinned annotation continues to be updated for backwards-compat's sake in case it needs to be turned off.
    • In another release we will move it to Enabled where lastPinned is dropped.

Release Note

Responsive revision garbage collection is on (allowed) by default.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 8, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/API API objects and controllers labels Sep 8, 2020
knative-prow-robot
knative-prow-robot reviewed Sep 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whaught: 0 warnings.

Details

In response to this:

Fixes #8208

Proposed Changes

  • Move the responsive garbage collection to Allowed. In this state the new collector will run, but the lastPinned annotation continues to be updated for backwards-compat's sake in case it needs to be turned off.
    • In another release we will move it to Enabled where lastPinned is dropped.

Release Note

Responsive revision garbage collection is on (allowed) by default.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2020
@whaught whaught changed the title [WIP] Move responsive-gc feature to allowed Move responsive-gc feature to allowed Sep 8, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2020
@whaught
Copy link
Copy Markdown
Contributor Author

whaught commented Sep 8, 2020

/assign @vagababov @tcnghia @dprotaso

@vagababov
Copy link
Copy Markdown
Contributor

vagababov commented Sep 8, 2020

/lgtm
/assign @mattmoor

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2020
@mattmoor
Copy link
Copy Markdown
Member

mattmoor commented Sep 8, 2020

Let's get this baking, and try to keep things clean in case we need to roll back.

/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Sep 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020
@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Sep 8, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:

pkg/reconciler/accessor/networking.TestReconcileCertificateUpdate

@whaught
Copy link
Copy Markdown
Contributor Author

whaught commented Sep 8, 2020

/test pull-knative-serving-unit-tests

@knative-prow-robot knative-prow-robot merged commit 482b183 into knative:master Sep 8, 2020
@whaught whaught deleted the enable-gc branch January 13, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@tcnghia tcnghia Awaiting requested review from tcnghia

@ZhiminXiang ZhiminXiang Awaiting requested review from ZhiminXiang

Assignees

@dprotaso dprotaso

@tcnghia tcnghia

@vagababov vagababov

@mattmoor mattmoor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

More aggressive Revision GC settings

8 participants

@whaught @vagababov @mattmoor @knative-prow-robot @knative-test-reporter-robot @dprotaso @tcnghia @googlebot