Move responsive gc to enabled by default

config/core/configmaps/features.yaml

@@ -20,7 +20,7 @@ metadata:
   labels:
     serving.knative.dev/release: devel
   annotations:
-    knative.dev/example-checksum: "f31ab799"
+    knative.dev/example-checksum: "2d4c16b9"
 data:
   _example: |
     ################################
@@ -114,7 +114,7 @@ data:
     # dereferenced by Routes. This allows us to reap revisions shortly after
     # they are no longer active.
     # See: https://knative.dev/docs/serving/feature-flags/#responsive-revision-garbage-collector
-    responsive-revision-gc: "allowed"
+    responsive-revision-gc: "enabled"
 
     # Controls whether tag header based routing feature are enabled or not.
     # 1. Enabled: enabling tag header based routing

pkg/apis/config/features.go

@@ -48,7 +48,7 @@ func defaultFeaturesConfig() *Features {
 		PodSpecRuntimeClassName: Disabled,
 		PodSpecSecurityContext:  Disabled,
 		PodSpecTolerations:      Disabled,
-		ResponsiveRevisionGC:    Allowed,
+		ResponsiveRevisionGC:    Enabled,
 		TagHeaderBasedRouting:   Disabled,
 	}
 }

pkg/reconciler/service/resources/configuration.go

@@ -32,7 +32,7 @@ import (
 
 // MakeConfiguration creates a Configuration from a Service object.
 func MakeConfiguration(service *v1.Service) (*v1.Configuration, error) {
-	return MakeConfigurationFromExisting(service, &v1.Configuration{}, cfgmap.Allowed)
+	return MakeConfigurationFromExisting(service, &v1.Configuration{}, cfgmap.Enabled)
 }
 
 // MakeConfigurationFromExisting creates a Configuration from a Service object given an existing Configuration.

pkg/reconciler/service/resources/configuration_test.go

@@ -41,7 +41,7 @@ func TestConfigurationSpec(t *testing.T) {
 	}
 	expectOwnerReferencesSetCorrectly(t, c.OwnerReferences)
 
-	if got, want := len(c.Labels), 2; got != want {
+	if got, want := len(c.Labels), 1; got != want {
 		t.Errorf("expected %d labels got %d", want, got)
 	}
 	if got, want := c.Labels[serving.ServiceLabelKey], testServiceName; got != want {

pkg/reconciler/service/service_test.go

@@ -351,14 +351,12 @@ func TestReconcile(t *testing.T) {
 			// Mutate the Service to add some more labels
 			DefaultService("update-child-labels-ignore-route-label", "foo",
 				WithRunLatestRollout, WithInitSvcConditions, WithServiceLabel("new-label", "new-value")),
-			config("update-child-labels-ignore-route-label", "foo",
-				WithRunLatestRollout, WithConfigLabel("serving.knative.dev/route", "update-child-labels-ignore-route-label")),
+			config("update-child-labels-ignore-route-label", "foo", WithRunLatestRollout),
 			route("update-child-labels-ignore-route-label", "foo", WithRunLatestRollout),
 		},
 		Key: "foo/update-child-labels-ignore-route-label",
 		WantUpdates: []clientgotesting.UpdateActionImpl{{
-			Object: config("update-child-labels-ignore-route-label", "foo", WithRunLatestRollout, WithConfigLabel("new-label", "new-value"),
-				WithConfigLabel("serving.knative.dev/route", "update-child-labels-ignore-route-label")),
+			Object: config("update-child-labels-ignore-route-label", "foo", WithRunLatestRollout, WithConfigLabel("new-label", "new-value")),
 		}, {
 			Object: route("update-child-labels-ignore-route-label", "foo", WithRunLatestRollout, WithRouteLabel(map[string]string{"new-label": "new-value",
 				"serving.knative.dev/service": "update-child-labels-ignore-route-label"})),

test/conformance/api/v1/util.go

@@ -183,9 +183,6 @@ func validateLabelsPropagation(t pkgTest.T, objects v1test.ResourceObjects, name
 	if config.Labels["serving.knative.dev/service"] != names.Service {
 		return fmt.Errorf("expect Service name in Configuration label %q but got %q ", names.Service, config.Labels["serving.knative.dev/service"])
 	}
-	if config.Labels["serving.knative.dev/route"] != names.Route {
-		return fmt.Errorf("expect Route name in Configuration label %q but got %q ", names.Route, config.Labels["serving.knative.dev/route"])
-	}
 
 	t.Log("Validate Labels on Route Object")
 	route := objects.Route