Skip to content

Fixes noticed by Ahmed #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Aug 5, 2021
Merged

Fixes noticed by Ahmed #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions specs/eventing/control-plane.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ Broker MUST provide a `status.address.url` which accepts all valid CloudEvents
and MUST attempt to forward the received events for filtering to each associated
Trigger whose `Ready` condition is `true`. As described in the
[Trigger Lifecycle](#trigger-lifecycle) section, a Broker MAY forward events to
an associated Trigger destination which which does not currently have a `true`
an associated Trigger destination which does not currently have a `true`
`Ready` condition, including events received by the Broker before the Trigger
was created.

Expand Down Expand Up @@ -247,7 +247,7 @@ When a Subscription becomes associated with a Channel (either due to creating
the Subscription or the Channel), the Subscription MUST only set the `Ready`
condition to `true` after the Channel has been configured to send all future
events to the Subscription's `spec.subscriber`. The Channel MAY send some events
to the Subscription before prior to the Subscription's `Ready` condition being
to the Subscription prior to the Subscription's `Ready` condition being
set to `true`. When a Subscription is deleted, the Channel MAY send some
additional events to the Subscription's `spec.subscriber` after the deletion.

Expand Down