Skip to content

update(prow-config): Add kn-plugin CI configs#2706

Merged
knative-prow-robot merged 5 commits into
knative:mainfrom
rhuss:pr/add-kn-plugin-service-log
Mar 10, 2021
Merged

update(prow-config): Add kn-plugin CI configs#2706
knative-prow-robot merged 5 commits into
knative:mainfrom
rhuss:pr/add-kn-plugin-service-log

Conversation

@rhuss
Copy link
Copy Markdown
Contributor

@rhuss rhuss commented Mar 10, 2021

i.e. CI config for the following plugins are added with this PR:

  • kn-plugin-service-log
  • kn-plugin-source-kamelet
  • kn-plugin-migration

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 10, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 10, 2021
@rhuss
Copy link
Copy Markdown
Contributor Author

rhuss commented Mar 10, 2021

/hold

Adding more missing plugin prow configuration so that we can do the setup in one go.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2021
@rhuss rhuss changed the title update(prow-config): Add kn-plugin-service-log CI config update(prow-config): Add kn-plugin CI configs Mar 10, 2021
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 10, 2021
@rhuss
Copy link
Copy Markdown
Contributor Author

rhuss commented Mar 10, 2021

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2021
Copy link
Copy Markdown
Contributor

@chizhg chizhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2021
@knative-prow-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chizhg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2021
@rhuss rhuss force-pushed the pr/add-kn-plugin-service-log branch from a26dd66 to 57cbc9b Compare March 10, 2021 17:53
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2021
@chizhg
Copy link
Copy Markdown
Contributor

chizhg commented Mar 10, 2021

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2021
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2021
@rhuss
Copy link
Copy Markdown
Contributor Author

rhuss commented Mar 10, 2021

@chizhg sorry, forgot to rebase before submitting the PR. PTAL.

@dsimansk
Copy link
Copy Markdown
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2021
@knative-prow-robot knative-prow-robot merged commit 957288b into knative:main Mar 10, 2021
@knative-prow-robot
Copy link
Copy Markdown
Collaborator

@rhuss: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file config/prod/prow/jobs/config.yaml
Details

In response to this:

i.e. CI config for the following plugins are added with this PR:

  • kn-plugin-service-log
  • kn-plugin-source-kamelet
  • kn-plugin-migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants