Add a new integration tests job for knative client for latest release#954
Merged
knative-prow-robot merged 1 commit intoknative:masterfrom Jun 29, 2019
houshengbo:add-pull-knative-client-integration-tests-previous-release
Merged
Add a new integration tests job for knative client for latest release#954knative-prow-robot merged 1 commit intoknative:masterfrom houshengbo:add-pull-knative-client-integration-tests-previous-release
knative-prow-robot merged 1 commit intoknative:masterfrom
houshengbo:add-pull-knative-client-integration-tests-previous-release
Conversation
knative-prow-robot
added
size/M
adrcunha
requested review from
adrcunha
and removed request for
ericKlawitter and
srinivashegde86
Contributor
|
/hold This can't be merged until ./test/presubmit-integration-tests-previous-release.sh is available in knative/client. |
knative-prow-robot
added
the
do-not-merge/hold
houshengbo
changed the title
Author
|
/test pull-knative-test-infra-unit-tests |
Contributor
|
/approve |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, houshengbo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Contributor
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
Contributor
|
/retest |
Cynocracy
pushed a commit
to Cynocracy/test-infra
that referenced
this pull request
Jun 13, 2020
…entity (knative#954) * always enable workload identity for perf test cluster creation * fix unit tests * add comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does, why we need it:
Which issue(s) this PR fixes:
Fixes #knative/client#168
Depends-On: #knative/client#170
Special notes to reviewers:
User-visible changes in this PR: