Skip to content
This repository was archived by the owner on Dec 15, 2021. It is now read-only.

update build files for release 0.17#203

Merged
knative-prow-robot merged 2 commits intoknative:masterfrom
RichieEscarez:0.17build
Aug 20, 2020
Merged

update build files for release 0.17#203
knative-prow-robot merged 2 commits intoknative:masterfrom
RichieEscarez:0.17build

Conversation

@RichieEscarez
Copy link
Contributor

Update knative.dev site build to include new release-0.17 branch. Also:

@RichieEscarez RichieEscarez added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 20, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 20, 2020
@RichieEscarez
Copy link
Contributor Author

this is currently blocked by knative/docs#2763

@RichieEscarez RichieEscarez added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2020
@RichieEscarez
Copy link
Contributor Author

Staging looks good: https://deploy-preview-203--knative.netlify.app/

@ellenevans this is ready for review/merge

@RichieEscarez RichieEscarez removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2020
@ellenevans
Copy link
Contributor

"Some checks were not successful" - have you cleared them up?

@RichieEscarez
Copy link
Contributor Author

Sorry forgot to mention that you can ignore those. It looks like Evan hooked up some test builds (not sure what they are but are likely connected to #155).

@ellenevans
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2020
@RichieEscarez
Copy link
Contributor Author

@evankanderson it looks like your builds are blocking Prow from merging. Do I need to force merge from the command line to get past those failures?

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2020
@ellenevans
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2020
@knative-prow-robot knative-prow-robot merged commit f4ef166 into knative:master Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants