Migrate create-github-app-token from app-id to client-id#121
Merged
Conversation
lex57ukr
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Silences the deprecation warning emitted by
actions/create-github-app-tokenin the publish workflow. Theapp-idinput was deprecated in v3.1.0 (2026-04-11) in favour ofclient-id, and the action is currently pinned at v3.1.1 so thewarning is emitted on every release run. Moving to
client-idalso uses the GitHub App's public Client ID via a repo variable rather than the numeric App ID from a secret, matching upstream's recommended usage.Related Issues
Fixes #120
Changes
app-id: ${{ secrets.APP_ID }}withclient-id: ${{ vars.APP_CLIENT_ID }}at.github/workflows/publish.yml:189.Further Comments
APP_CLIENT_IDrepo variable has been populated out-of-band with the GitHub App's Client ID.APP_IDrepo secret once this lands and the next release run is green.knight-owl-dev/keystone#352,knight-owl-dev/keystone-cli#184,knight-owl-dev/homebrew-tap#54,knight-owl-dev/apt#59.