Fix docs build: remove NODE_OPTIONS strip-types flag#307
Conversation
Bun handles TypeScript natively, so the Node flag is unnecessary and causes "not allowed in NODE_OPTIONS" error in CI. Also fix predev to use bun run instead of npm run. Verified: bun run build succeeds, all 5 examples + glossary in dist. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request modifies Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Fixes the tko.io (Astro/Starlight) docs site build when run under Bun by removing an incompatible NODE_OPTIONS=--experimental-strip-types flag, and aligns the predev script with the repo’s Bun-first workflow.
Changes:
- Remove
NODE_OPTIONS=--experimental-strip-typesfrom the Astrodev,build,preview, andcheckscripts. - Switch
predevfromnpm run prebuildtobun run prebuild.
Summary
The docs build has been failing because
NODE_OPTIONS=--experimental-strip-typesis not allowed when Bun spawns Node for Astro. Bun handles TypeScript natively — the flag is unnecessary.Also fixes
predevto usebun runinstead ofnpm run.Verified locally
cd tko.io && bun run build— succeeds, 57 pages builtdist/examples/dist/agents/🤖 Generated with Claude Code
Summary by CodeRabbit
bunpackage manager for build scripts.