Skip to content

Fix jQuery reference in style update function#339

Merged
brianmhunt merged 1 commit into
mainfrom
pc/fix_jquery_option
Apr 20, 2026
Merged

Fix jQuery reference in style update function#339
brianmhunt merged 1 commit into
mainfrom
pc/fix_jquery_option

Conversation

@phillipc
Copy link
Copy Markdown
Member

@phillipc phillipc commented Apr 20, 2026

Style binding references global jQuery instead of options.jQuery

Issue: Guards with options.jQuery but calls bare global jQuery(element). In module environments where jQuery is not a global, this throws ReferenceError.

Detected in #297

Summary by CodeRabbit

  • Bug Fixes
    • Improved style update functionality reliability by adjusting how jQuery is referenced.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4cac2d86-c451-415a-bbae-29cc4862961f

📥 Commits

Reviewing files that changed from the base of the PR and between 802ac55 and 5d6603d.

📒 Files selected for processing (1)
  • packages/binding.core/src/style.ts

📝 Walkthrough

Walkthrough

Updated the style.update jQuery branch to use the jQuery instance from options.jQuery(element) instead of relying on a global jQuery(element) reference. The non-jQuery path and other style update logic remain unchanged.

Changes

Cohort / File(s) Summary
jQuery Instance Reference
packages/binding.core/src/style.ts
Changed jQuery invocation from global jQuery(element) to options.jQuery(element) to use the provided options instance.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 No globals here, just local ways,
Options passed through binding days,
jQuery flows where it should go,
Cleaner code with less to tow! 🌿

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing the jQuery reference in the style update function to use options.jQuery instead of the global jQuery.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pc/fix_jquery_option

Warning

Review ran into problems

🔥 Problems

Timed out fetching pipeline failures after 30000ms


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@phillipc phillipc requested a review from brianmhunt April 20, 2026 17:59
@brianmhunt brianmhunt merged commit 858b7fc into main Apr 20, 2026
9 checks passed
@brianmhunt brianmhunt deleted the pc/fix_jquery_option branch April 20, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants