Skip to content

Remove duplicate options import in computed.ts#347

Merged
phillipc merged 1 commit into
mainfrom
fix/computed-duplicate-options-import
Apr 22, 2026
Merged

Remove duplicate options import in computed.ts#347
phillipc merged 1 commit into
mainfrom
fix/computed-duplicate-options-import

Conversation

@phillipc
Copy link
Copy Markdown
Member

@phillipc phillipc commented Apr 20, 2026

Summary

Removes the duplicate options import from packages/computed/src/computed.ts. The module was importing both options and options as koOptions from @tko/utils. The bare options reference at line 430 is replaced with the existing koOptions alias.

Detected in #297

Verification

Full test suite passes (5371 tests).

The module imported both 'options' and 'options as koOptions' from
@tko/utils. Remove the bare 'options' import and use the existing
'koOptions' alias at the one call site.
@phillipc phillipc requested a review from brianmhunt April 20, 2026 20:00
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

Warning

Rate limit exceeded

@phillipc has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 45 minutes and 2 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 45 minutes and 2 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a5eb07c4-8397-4d29-b7c2-37c1fdaee5ae

📥 Commits

Reviewing files that changed from the base of the PR and between 6629d63 and 0b7a9f3.

📒 Files selected for processing (1)
  • packages/computed/src/computed.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/computed-duplicate-options-import

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@phillipc
Copy link
Copy Markdown
Member Author

The reason for using the koOptions alias is name conflicts with ComputedOptions.

Copy link
Copy Markdown
Member

@brianmhunt brianmhunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @phillipc

@phillipc phillipc merged commit f670aa8 into main Apr 22, 2026
9 checks passed
@phillipc phillipc deleted the fix/computed-duplicate-options-import branch April 22, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants