🐛 Add error callback to AMD require in component loader

[phillipc]

Problem

The AMD require call in possiblyGetConfigFromAmd (packages/utils.component/src/loaders.ts) passed only a success callback — no error callback. When AMD module resolution fails, the error is silently swallowed, leaving the component load hanging with no diagnostic.

Fix

Add an explicit error callback (third argument) to the AMD require call that surfaces the failure through the existing errorCallback mechanism, producing a clear message like:

Component 'my-comp': Failed to load AMD module: some/module — Error details…

Changes

• packages/utils.component/src/loaders.ts: Add error callback to the (window.amdRequire || window.require) call.

Verification

• All 106 existing utils.component tests pass.
• No API surface change — purely an additive error path.

Summary by CodeRabbit

• Bug Fixes
  • Improved module loading error messages: failures now include the module name and more detailed diagnostic text (when available) to help identify root causes.
  • Ensures consistent behavior when using a browser loader, preserving previous behavior for other cases.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e4fce4d3-babd-4e1a-84b3-398b88ec15a0

📥 Commits

Reviewing files that changed from the base of the PR and between 726157b and 98ff24f.

📒 Files selected for processing (1)

• packages/utils.component/src/loaders.ts

---

📝 Walkthrough

Walkthrough

When config.require is a string and an AMD loader (window.amdRequire or window.require) exists, the loader is stored in amdRequire and invoked with an added error callback. On failure the error handler calls errorCallback with "Failed to load AMD module: " plus the original error message when available.

Changes

Cohort / File(s)	Summary
AMD Loader Error Handling packages/utils.component/src/loaders.ts	Store detected AMD loader in amdRequire and call it with a third argument: an error handler. On AMD load failure, invoke errorCallback with a message prefixed by Failed to load AMD module: <moduleName> and append the underlying error text when present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 I hopped through code at break of dawn,

found a module that would not respond.
I added a handler, sharp and quick,
now failures tell us what went sick.
Debugging carrots—one sweet bite!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Add error callback to AMD require in component loader' (minus emoji) accurately describes the main change—adding error handling to AMD module loading.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/amd-require-error-callback

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/utils.component/src/loaders.ts`:
- Around line 278-280: Remove the leading semicolon before the AMD loader call
and make the err handling robust so non-Error truthy values don't produce "—
undefined"; specifically, change the call that uses (window.amdRequire ||
window.require)([config.require], callback, function (err) {
errorCallback('Failed to load AMD module: ' + config.require + (err ? ' — ' +
err.message : '')) }) to omit the initial semicolon and build the trailing error
text defensively (e.g., use err?.message ?? String(err) or similar) when
invoking errorCallback so config.require, callback,
window.amdRequire/window.require, and errorCallback are used directly and no " —
undefined" is emitted.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0c386549-cd24-474a-9470-5bd14eb9c578

📥 Commits

Reviewing files that changed from the base of the PR and between f670aa8 and 726157b.

📒 Files selected for processing (1)

• packages/utils.component/src/loaders.ts