Skip to content
This repository was archived by the owner on Apr 17, 2020. It is now read-only.

WIP: feat: support json in WHERE clauses#37

Open
joelmukuthu wants to merge 2 commits intomasterfrom
feat/json-in-where-clauses
Open

WIP: feat: support json in WHERE clauses#37
joelmukuthu wants to merge 2 commits intomasterfrom
feat/json-in-where-clauses

Conversation

@joelmukuthu
Copy link
Collaborator

@joelmukuthu joelmukuthu commented Oct 21, 2018

Closes #4
Closes knorm/knorm#52

@joelmukuthu joelmukuthu force-pushed the feat/json-in-where-clauses branch from d3f545d to 9d7b9fc Compare October 22, 2018 21:46
joelmukuthu added a commit to knorm/knorm that referenced this pull request Oct 24, 2018
@joelmukuthu joelmukuthu force-pushed the feat/json-in-where-clauses branch from 9d7b9fc to 957fa64 Compare October 24, 2018 21:26
@joelmukuthu joelmukuthu changed the title feat: support json in WHERE clauses WIP: feat: support json in WHERE clauses Mar 12, 2019
@joelmukuthu
Copy link
Collaborator Author

Work on this was paused because knorm needs to support calling this.sql.where more than once when preparing a single where value. Here, query.where({ foo: { bar: 'bar', baz: 'baz' } }) in principle translates to this.sql.where({ bar: 'bar' }); this.sql.where({ baz: 'baz' });. This requires some refactors in knorm.

In addition, it would be nice to figure out what to do with nested fields (in the JSON where spec) before proceeding with this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant