Add RateLimitLogger to unify rate-limit warnings#5205
Open
zegarekk wants to merge 1 commit intoknowm:developfrom
Open
Add RateLimitLogger to unify rate-limit warnings#5205zegarekk wants to merge 1 commit intoknowm:developfrom
zegarekk wants to merge 1 commit intoknowm:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new helper class
RateLimitLoggertoxchange-coreto standardize how API rate-limit warnings are logged.Motivation
Different exchange modules currently log rate-limit issues inconsistently.
The new class ensures that all such warnings:
Changes
xchange-core/src/main/java/org/knowm/xchange/utils/RateLimitLogger.javaxchange-binanceandxchange-krakenmodules to use it (example in next commit)Benefits
✅ Unified rate-limit log format
✅ Reduced log spam
✅ Easier future maintenance
Checklist
Example output