application: removed koa-convert (v3) #1011
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl0w
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1011 +/- ##
======================================
Coverage 100% 100%
======================================
Files 5 5
Lines 393 389 -4
======================================
- Hits 393 389 -4
Continue to review full report at Codecov.
|
Member
|
IMO we can hold this change until node 8 into LTS, then we can drop support of koa 1.x and start koa 3.x, so we don't need to maintain three branches at the same time. |
iyuq
reviewed
Jun 26, 2017
Contributor
iyuq
left a comment
iyuq
left a comment
There was a problem hiding this comment.
agree to wait for node.js 8 betome LTS.
Contributor
Author
|
@dead-horse I agree. I'll honour maintaining the PR unless you want me to close it for now? |
fl0w
force-pushed
the
rm-koa-convert
branch
from
0c33c9d to
4c88535
Compare
jonathanong
approved these changes
Nov 6, 2017
Closed
3imed-jaberi
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a separate commit for added test and keeping the check with a throw instead.If d89e72f is an excessive guard, I'll just revert/squash it pre-merge.