Skip to content

Change default value of autoConnect & autoReconnect option #39

@usirin

Description

@usirin

I am finding myself to write new Kite({url: '...', autoConnect: false, autoReconnect: false}) all the time in following scenarios:

  • writing unit tests for kite
  • if i am initializing other objects other than kite as well, i want to have a preparation phase and want to call kite.connect() afterwards.
  • if i want to have a kite as a singleton e.g export default new Kite({ ... })

Having to write auto{Connect,Reconnect} all the time is a little bit tedious.

I would probably not need autoReconnect, since it's about connecting after disconnecting. But i still would expect from an object to connect something when i tell it to.

@gokmen I think this is good enough to be one of our breaking changes for moving forward to v2.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions