Optimize honeycomb sigil rendering with lightweight glyphs#175
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .chakra-crown { --hex-tint: 210 200 255; } | ||
| .chakra-unknown { --hex-tint: 120 190 255; } | ||
| } |
There was a problem hiding this comment.
Remove stray closing brace to avoid CSS parse failure
There is an unmatched } after .chakra-unknown; Vite/PostCSS treats this as a CSS syntax error, which can fail the build or cause subsequent rules (like .sigilHex:hover) to be dropped. This will surface when running the dev server or build pipeline that parses CSS strictly, so the extra brace should be removed to keep the stylesheet valid.
Useful? React with 👍 / 👎.
Motivation
Description
KaiSigilrendering inside honeycomb cells with a lightweight placeholder element by removing the import and usage fromSigilHoneycombExplorer.tsxand rendering adiv.sigilHexGlyphSimpleinstead.SIGIL_RENDER_CACHE) and theuseDeferredSigilRenderscheduling logic to simplify rendering logic and eliminate idle-callback scheduling.SigilHoneycomb.cssto add.sigilHexGlyphSimplestyling and chakra tint variables (e.g..chakra-root,.chakra-sacral, etc.) to show colored, clipped shapes with a small drop shadow instead of full glyph SVGs.src/components/SigilExplorer/SigilHoneycombExplorer.tsxandsrc/components/SigilExplorer/SigilHoneycomb.cssand preserve existing selection/interaction behavior.Testing
npm run dev -- --host 0.0.0.0 --port 4173and the server started successfully.http://127.0.0.1:4173/explorerand capture a screenshot which completed successfully.Codex Task