Skip to content

Reset note send reservation and nonce when Send Φ input changes#330

Merged
kojibai merged 1 commit intocodex/add-custom-amount-flow-for-exhale-notefrom
codex/fix-re-export-to-handle-send-properly
Jan 31, 2026
Merged

Reset note send reservation and nonce when Send Φ input changes#330
kojibai merged 1 commit intocodex/add-custom-amount-flow-for-exhale-notefrom
codex/fix-re-export-to-handle-send-properly

Conversation

@kojibai
Copy link
Copy Markdown
Owner

@kojibai kojibai commented Jan 31, 2026

Motivation

  • Fix a bug where ensureNoteSend would return early when sendCommittedRef.current was set, allowing subsequent exports to embed a different displayed Φ than the reserved/recorded amount and causing a ledger/printed-note mismatch.
  • Instead of freezing the input, invalidate the prior reservation when the user edits the Send Φ input so a fresh reservation will be made on the next export.

Description

  • Add lastSendPhiInputRef and a useEffect that watches sendPhiInput and locked to reset sendCommittedRef.current, clear noteSendResult, and generate a new sendNonce when the amount input changes after a committed send (sendPhiInput edited while locked).
  • Change the local merged variable in buildNoteSendPayload to be typed as Partial<NoteSendPayload> to avoid a TypeScript error when reading parentCanonical from an empty result object.

Testing

  • No automated tests were run.

Codex Task

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
phi-network-5aii Ready Ready Preview, Comment Jan 31, 2026 0:33am

Request Review

@kojibai kojibai merged commit bd3175b into codex/add-custom-amount-flow-for-exhale-note Jan 31, 2026
1 of 2 checks passed
kojibai added a commit that referenced this pull request Jan 31, 2026
## Release v42.7.0 — ExhaleNote Receipts, Claims, and Proof-Safe Exports

This release rolls up everything shipped after **v42.6.0** into a clean minor bump. The headline: **ExhaleNote is now “receipt-grade”**—custom amounts, USD visibility, proof-bundle metadata carried through exports, PDF/PNG reliability upgrades, and a full **claim/unclaim + registry sync** loop so notes can be treated like portable value objects (not just UI). ([GitHub][1])

---

## ✨ Highlights

* **Custom amount ExhaleNote flow** + safer “send reservation” behavior when editing amounts. ([GitHub][2])
* **USD value shown on ExhaleNotes** (making receipts legible to non-Φ-native viewers). ([GitHub][1])
* **Exports upgraded**: proof bundle metadata included in ExhaleNote exports, and verification links/QRs now resolve correctly to the verifier. ([GitHub][1])
* **Receipt outputs hardened**: PDF rendering/parsing fixes (including large proof bundles), plus PNG download path improvements. ([GitHub][2])
* **Claim system shipped**: claim/unclaim mechanics + claim status propagation (local sigil registry + remote/global registry sync). ([GitHub][2])
* **UI declutter**: proof/signature controls hidden where they don’t belong in ExhaleNote upload contexts. ([GitHub][2])

---

## 🚀 What shipped

### 1) ExhaleNote value + receipt UX

* Add **USD value** to ExhaleNote outputs and related receipt metadata. ([GitHub][1])
* Add **custom ExhaleNote sends** + receipt metadata (supports user-chosen amount flows). ([GitHub][2])
* Fix re-export behavior so sending/exporting stays correct after edits (and reset reservations properly on amount changes). ([GitHub][2])

### 2) Proof-carrying exports + verifier link correctness

* ExhaleNote exports now include **proof bundle metadata** (so exported artifacts remain self-describing and verifiable). ([GitHub][1])
* QR + verify link construction fixed and hardened:

  * “Fix ExhaleNote QR to use verifier URL”
  * “Derive full verify URL for note QR”
  * “Fix verify URLs in note PDFs”
  * “Fix exhale note QR verify link” ([GitHub][1])

### 3) PDF pipeline hardening (real-world proof sizes)

* Fixes for **PDF rendering and verification issues**. ([GitHub][2])
* PDF parsing hardened to handle **large proof bundles** safely. ([GitHub][2])
* Restored/maintained correct receipt composition (e.g., cover page restoration) and ensured verification fields are populated/locked consistently on render. ([GitHub][2])

### 4) ExhaleNote claim/unclaim + registry synchronization

* Implement **unclaim → claim** function (so ownership state can be intentionally changed, not just inferred). ([GitHub][2])
* Claim state is now:

  * **Marked on SVG download**
  * **Persisted in sigil registry**
  * **Synced from remote registry**
  * **Broadcast to global registry**
  * Refreshed with ledger updates ([GitHub][2])

### 5) Scanning + UI polish

* Fix QR scanning issues and tighten the end-to-end scan → verify loop. ([GitHub][2])
* Hide signature/proof buttons for ExhaleNote where they caused confusion or implied actions that shouldn’t exist in that context. ([GitHub][2])

---

## ✅ Merged PRs included in this release (since v42.6.0)

* #327 — Update ExhaleNote for verify page ([GitHub][1])
* #328 — Add USD value to ExhaleNote ([GitHub][1])
* #329 — Custom amount flow for ExhaleNote ([GitHub][2])
* #330 — Fix re-export to handle send properly ([GitHub][2])
* #331 — Fix PDF rendering and verification issues ([GitHub][2])
* #332 — Handle large proof bundles in PDF parsing ([GitHub][2])
* #333 — Update PDF generation for ExhaleNote ([GitHub][2])
* #334 — Implement unclaim-to-claim function ([GitHub][2])
* #335 — Update ExhaleNote to PNG download ([GitHub][2])
* #336 — Fix QR code scanning issue ([GitHub][2])
* #338 — Hide signature/proof buttons for ExhaleNotes ([GitHub][2])

---

## 🧩 Dev / Ops Notes

* This release includes multiple patch bumps along the way (v42.6.1 → v42.6.9) that track incremental shipping; **v42.7.0** is the consolidated “clean cut” minor that captures the whole ExhaleNote receipt/claim/export hardening wave. ([GitHub][1])
* No breaking routing changes indicated in the commit history; this is primarily a **capability + correctness** upgrade across exports, PDFs, QR/verify paths, and claim state propagation. ([GitHub][2])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant